Bug 183232

Summary: Layout Test accessibility/mac/accessibility-make-first-responder.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, lforschler, n_wang, rniwa, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=182752
Attachments:
Description Flags
patch
none
patch none

Description Matt Lewis 2018-02-28 16:43:01 PST
The following layout test is flaky on [insert platform]

accessibility/mac/accessibility-make-first-responder.html

Probable cause:

Failed since being added in 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Faccessibility-make-first-responder.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229106%20(3180)/results.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/accessibility/mac/accessibility-make-first-responder-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/accessibility/mac/accessibility-make-first-responder-actual.txt
@@ -6,7 +6,7 @@
 DOM focus
 Window is still the first responder: true
 Accessibility focus
-Window is still the first responder: false
+Window is still the first responder: true
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Matt Lewis 2018-02-28 16:46:14 PST
The platform is currently High Sierra Release WK2
Comment 2 Nan Wang 2018-02-28 17:29:07 PST
Created attachment 334788 [details]
patch

fix the test
Comment 3 chris fleizach 2018-02-28 17:30:34 PST
Comment on attachment 334788 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334788&action=review

> LayoutTests/ChangeLog:11
> +

extra new line

> LayoutTests/accessibility/mac/accessibility-make-first-responder.html:62
> +            setTimeout(

setTimeout(function() {
Comment 4 Nan Wang 2018-02-28 17:37:43 PST
Created attachment 334791 [details]
patch

update
Comment 5 WebKit Commit Bot 2018-02-28 18:15:28 PST
Comment on attachment 334791 [details]
patch

Clearing flags on attachment: 334791

Committed r229118: <https://trac.webkit.org/changeset/229118>
Comment 6 WebKit Commit Bot 2018-02-28 18:15:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-02-28 18:17:27 PST
<rdar://problem/38010208>