Bug 183212

Summary: [GStreamer] text samples no longer processed
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+, calvaris: commit-queue-

Description Philippe Normand 2018-02-28 06:27:45 PST 
Inband subtitles are no longer rendered. Will attach a patch.
Comment 1 Philippe Normand 2018-02-28 06:30:23 PST 
Created attachment 334742 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-02-28 23:51:56 PST 
Comment on attachment 334742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334742&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:986
> +        for (auto track : m_textTracks.values()) {

Nit: you better do auto& instead.
Comment 3 Philippe Normand 2018-03-01 01:30:14 PST 
Committed r229127: <https://trac.webkit.org/changeset/229127>
Comment 4 Radar WebKit Bug Importer 2018-03-01 01:31:39 PST 
<rdar://problem/38019193>