Bug 183189

Summary: Ensure target triple is propagated correctly to DerivedSources.make
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Tim Horton
Reported 2018-02-27 15:32:55 PST
Ensure target triple is propagated correctly to DerivedSources.make
Attachments
Patch (6.70 KB, patch)
2018-02-27 15:33 PST, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-02-27 15:33:24 PST
Created attachment 334710 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-02-27 15:34:04 PST
<rdar://problem/37959694>
mitz
Comment 3 2018-02-27 15:39:28 PST
Comment on attachment 334710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334710&action=review > Source/WebCore/Configurations/Base.xcconfig:121 > +LLVM_TARGET_TRIPLE_SUFFIX = $(inherited); I can easily picture myself trying to be helpful by removing this seemingly-redundant assignment. Can you add a comment explaining why it’s needed?
Tim Horton
Comment 4 2018-02-27 15:40:22 PST
Fair enough :)
Tim Horton
Comment 5 2018-02-27 15:46:02 PST
https://trac.webkit.org/changeset/229081/webkit
Note You need to log in before you can comment on or make changes to this bug.