Bug 183189

Summary: Ensure target triple is propagated correctly to DerivedSources.make
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Severity: Normal CC: aestes, bdakin, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch mitz: review+

Description Tim Horton 2018-02-27 15:32:55 PST
Ensure target triple is propagated correctly to DerivedSources.make
Comment 1 Tim Horton 2018-02-27 15:33:24 PST
Created attachment 334710 [details]
Comment 2 Radar WebKit Bug Importer 2018-02-27 15:34:04 PST
Comment 3 mitz 2018-02-27 15:39:28 PST
Comment on attachment 334710 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=334710&action=review

> Source/WebCore/Configurations/Base.xcconfig:121
> +LLVM_TARGET_TRIPLE_SUFFIX = $(inherited);

I can easily picture myself trying to be helpful by removing this seemingly-redundant assignment. Can you add a comment explaining why it’s needed?
Comment 4 Tim Horton 2018-02-27 15:40:22 PST
Fair enough :)
Comment 5 Tim Horton 2018-02-27 15:46:02 PST