Bug 183185

Summary: Do not trigger a service worker match in case of document redirection if it will be already served by AppCache
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, japhet, koivisto, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews101 for mac-sierra
none
Patch for landing none

Description youenn fablet 2018-02-27 15:01:32 PST
In the future, we should check first service worker and then appcache.
Comment 1 youenn fablet 2018-02-27 16:22:23 PST
<rdar://problem/37693796>
Comment 2 youenn fablet 2018-02-27 16:31:31 PST
Created attachment 334713 [details]
Patch
Comment 3 Chris Dumez 2018-02-27 16:37:48 PST
Comment on attachment 334713 [details]
Patch

r=me
Comment 4 EWS Watchlist 2018-02-27 17:33:27 PST
Comment on attachment 334713 [details]
Patch

Attachment 334713 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6698356

New failing tests:
http/tests/appcache/main-resource-redirect-with-sw.html
Comment 5 EWS Watchlist 2018-02-27 17:33:28 PST
Created attachment 334719 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 youenn fablet 2018-02-27 17:40:38 PST
(In reply to Build Bot from comment #4)
> Comment on attachment 334713 [details]
> Patch
> 
> Attachment 334713 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/6698356
> 
> New failing tests:
> http/tests/appcache/main-resource-redirect-with-sw.html

Of course WK1 has no service worker and no async callbacks...
Comment 7 youenn fablet 2018-02-27 17:52:29 PST
Created attachment 334720 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-02-27 18:28:20 PST
Comment on attachment 334720 [details]
Patch for landing

Clearing flags on attachment: 334720

Committed r229086: <https://trac.webkit.org/changeset/229086>
Comment 9 WebKit Commit Bot 2018-02-27 18:28:21 PST
All reviewed patches have been landed.  Closing bug.