RESOLVED FIXED183185
Do not trigger a service worker match in case of document redirection if it will be already served by AppCache 
https://bugs.webkit.org/show_bug.cgi?id=183185
Summary Do not trigger a service worker match in case of document redirection if it w...
youenn fablet
Reported 2018-02-27 15:01:32 PST
In the future, we should check first service worker and then appcache.
Attachments
Patch (7.43 KB, patch)
2018-02-27 16:31 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.18 MB, application/zip)
2018-02-27 17:33 PST, EWS Watchlist 		no flags
Details
Patch for landing (10.47 KB, patch)
2018-02-27 17:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-02-27 16:22:23 PST
<rdar://problem/37693796>
youenn fablet
Comment 2 2018-02-27 16:31:31 PST
Created attachment 334713 [details] Patch
Chris Dumez
Comment 3 2018-02-27 16:37:48 PST
Comment on attachment 334713 [details] Patch r=me
EWS Watchlist
Comment 4 2018-02-27 17:33:27 PST
Comment on attachment 334713 [details] Patch Attachment 334713 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6698356 New failing tests: http/tests/appcache/main-resource-redirect-with-sw.html
EWS Watchlist
Comment 5 2018-02-27 17:33:28 PST
Created attachment 334719 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
youenn fablet
Comment 6 2018-02-27 17:40:38 PST
(In reply to Build Bot from comment #4) > Comment on attachment 334713 [details] > Patch > > Attachment 334713 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/6698356 > > New failing tests: > http/tests/appcache/main-resource-redirect-with-sw.html Of course WK1 has no service worker and no async callbacks...
youenn fablet
Comment 7 2018-02-27 17:52:29 PST
Created attachment 334720 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-02-27 18:28:20 PST
Comment on attachment 334720 [details] Patch for landing Clearing flags on attachment: 334720 Committed r229086: <https://trac.webkit.org/changeset/229086>
WebKit Commit Bot
Comment 9 2018-02-27 18:28:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.