Bug 183171

Summary: Rename samplePendingBuild to samplePendingBuildRequest
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, lforschler, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
rniwa: review+
Patch for landing none

Description Aakash Jain 2018-02-27 12:29:28 PST
Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js contains methods samplePendingBuild and samplePendingBuildDeprecated. These are poorly named functions as they actually represent a pending buildrequest. We should rename them to samplePendingBuildRequest and samplePendingBuildRequestDeprecated.
Comment 1 Aakash Jain 2018-02-27 12:31:30 PST
Created attachment 334700 [details]
Proposed patch
Comment 2 Ryosuke Niwa 2018-02-28 01:50:25 PST
Comment on attachment 334700 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334700&action=review

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:318
> +function samplePendingBuildRequest(buildRequestId, buildTime, builderName)

Should be samplePendingBuildRequests since this function returns a list of build requests
even though it always contains one.
Comment 3 Aakash Jain 2018-02-28 12:16:42 PST
Created attachment 334757 [details]
Patch for landing
Comment 4 Aakash Jain 2018-02-28 12:17:39 PST
> Should be samplePendingBuildRequests since this function returns a list of
> build requests even though it always contains one.
ok. Renamed.
Comment 5 WebKit Commit Bot 2018-02-28 13:55:01 PST
Comment on attachment 334757 [details]
Patch for landing

Clearing flags on attachment: 334757

Committed r229101: <https://trac.webkit.org/changeset/229101>
Comment 6 WebKit Commit Bot 2018-02-28 13:55:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-02-28 13:55:42 PST
<rdar://problem/37999819>