Bug 183159

Summary: Modernize FINALIZE_CODE and peer macros to use __VA_ARGS__ arguments.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: ASSIGNED    
Severity: Normal CC: ews-watchlist, fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2018-02-26 22:40:02 PST
Patch coming.
Attachments
proposed patch. (51.33 KB, patch)
2018-02-26 22:59 PST, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-26 22:40:49 PST
<rdar://problem/37930837>
Mark Lam
Comment 2 2018-02-26 22:59:17 PST
Created attachment 334674 [details] proposed patch.
EWS Watchlist
Comment 3 2018-02-26 23:02:14 PST
Attachment 334674 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:313: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:318: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:322: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:337: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:340: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 4 2018-02-26 23:05:24 PST
Comment on attachment 334674 [details] proposed patch. r=me.
Mark Lam
Comment 5 2018-02-27 10:10:07 PST
Thanks for the review. Landed in r229054:<https://trac.webkit.org/r229054>.
Note You need to log in before you can comment on or make changes to this bug.