Bug 183147

Summary: Fix WebCore includes within WebKitLegacy
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit Misc.Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, ews-watchlist, pvollan, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
thorton: review+
Patch none

Don Olmstead
Reported 2018-02-26 13:43:30 PST
WebKitLegacy uses relative includes for a number of WebCore files. It also uses config.h from WebCore in some places. The includes should all target the copied headers.
Attachments
Patch (19.82 KB, patch)
2018-02-26 13:50 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (19.82 KB, patch)
2018-02-26 14:01 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (18.79 KB, patch)
2018-02-26 15:01 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (18.79 KB, patch)
2018-02-26 15:05 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (19.74 KB, patch)
2018-02-26 15:09 PST, Don Olmstead 		thorton: review+
DetailsFormatted DiffDiff
Patch (21.11 KB, patch)
2018-02-26 15:46 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-02-26 13:50:45 PST
Created attachment 334640 [details] Patch Removes all config.h references minus the one in WebKitPrefix. Corrects all WebCore header includes.
EWS Watchlist
Comment 2 2018-02-26 13:52:23 PST
Attachment 334640 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2018-02-26 14:01:28 PST
Created attachment 334641 [details] Patch Make style queue happy
Don Olmstead
Comment 4 2018-02-26 15:01:11 PST
Created attachment 334646 [details] Patch Removed an additional include directory that shouldn't be there.
EWS Watchlist
Comment 5 2018-02-26 15:04:24 PST
Attachment 334646 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 6 2018-02-26 15:05:35 PST
Created attachment 334648 [details] Patch
Don Olmstead
Comment 7 2018-02-26 15:09:57 PST
Created attachment 334649 [details] Patch For real this time...
EWS Watchlist
Comment 8 2018-02-26 15:12:09 PST
Attachment 334649 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebKitLegacy/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 9 2018-02-26 15:34:33 PST
Comment on attachment 334649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334649&action=review Please get it building, but this seems great. > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Do what the bot says!
Don Olmstead
Comment 10 2018-02-26 15:46:05 PST
Created attachment 334656 [details] Patch
WebKit Commit Bot
Comment 11 2018-02-26 17:31:47 PST
Comment on attachment 334656 [details] Patch Clearing flags on attachment: 334656 Committed r229048: <https://trac.webkit.org/changeset/229048>
WebKit Commit Bot
Comment 12 2018-02-26 17:31:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-02-26 17:37:22 PST
<rdar://problem/37924737>
Note You need to log in before you can comment on or make changes to this bug.