Bug 183141

Summary: Add some more release logging related to DocumentWriter::addData crash
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2018-02-26 13:01:12 PST
Add some more release logging related to DocumentWriter::addData crash
Comment 1 youenn fablet 2018-02-26 13:09:45 PST
Created attachment 334636 [details]
Patch
Comment 2 youenn fablet 2018-02-26 13:18:20 PST
Created attachment 334637 [details]
Patch
Comment 3 youenn fablet 2018-02-26 15:18:28 PST
Created attachment 334650 [details]
Patch
Comment 4 Chris Dumez 2018-02-26 15:30:12 PST
Comment on attachment 334650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334650&action=review

> Source/WebCore/loader/DocumentLoader.cpp:947
> +        auto hasBegun = m_writer.begin(documentURL(), false);

bool is as long as auto and clearer.
Comment 5 youenn fablet 2018-02-26 15:46:59 PST
Created attachment 334657 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-02-26 16:20:06 PST
Comment on attachment 334657 [details]
Patch for landing

Clearing flags on attachment: 334657

Committed r229046: <https://trac.webkit.org/changeset/229046>
Comment 7 WebKit Commit Bot 2018-02-26 16:20:07 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-02-26 16:21:27 PST
<rdar://problem/37921709>