Bug 183141 - Add some more release logging related to DocumentWriter::addData crash
Summary: Add some more release logging related to DocumentWriter::addData crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-26 13:01 PST by youenn fablet
Modified: 2018-02-26 16:21 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.41 KB, patch)
2018-02-26 13:09 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.46 KB, patch)
2018-02-26 13:18 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2018-02-26 15:18 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.36 KB, patch)
2018-02-26 15:46 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-02-26 13:01:12 PST 
Add some more release logging related to DocumentWriter::addData crash
Comment 1 youenn fablet 2018-02-26 13:09:45 PST 
Created attachment 334636 [details]
Patch
Comment 2 youenn fablet 2018-02-26 13:18:20 PST 
Created attachment 334637 [details]
Patch
Comment 3 youenn fablet 2018-02-26 15:18:28 PST 
Created attachment 334650 [details]
Patch
Comment 4 Chris Dumez 2018-02-26 15:30:12 PST 
Comment on attachment 334650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334650&action=review

> Source/WebCore/loader/DocumentLoader.cpp:947
> +        auto hasBegun = m_writer.begin(documentURL(), false);

bool is as long as auto and clearer.
Comment 5 youenn fablet 2018-02-26 15:46:59 PST 
Created attachment 334657 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-02-26 16:20:06 PST 
Comment on attachment 334657 [details]
Patch for landing

Clearing flags on attachment: 334657

Committed r229046: <https://trac.webkit.org/changeset/229046>
Comment 7 WebKit Commit Bot 2018-02-26 16:20:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-02-26 16:21:27 PST 
<rdar://problem/37921709>