| Summary: | [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, bdakin, commit-queue, ntt13071999, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2018-02-23 21:39:23 PST
Created attachment 334561 [details]
Patch
Created attachment 334565 [details]
Fix macOS builds
Comment on attachment 334565 [details] Fix macOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=334565&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2509 > +- (WebCore::FloatSize)activeMinimumLayoutSize:(const CGRect&)bounds outViewSize:(WebCore::FloatSize&)viewSize This is a little ugly (the out arg), but I’m not sure what else to do. (In reply to Tim Horton from comment #3) > Comment on attachment 334565 [details] > Fix macOS builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334565&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2509 > > +- (WebCore::FloatSize)activeMinimumLayoutSize:(const CGRect&)bounds outViewSize:(WebCore::FloatSize&)viewSize > > This is a little ugly (the out arg), but I’m not sure what else to do. An alternative is to return the sizes in a struct — I'll make this tweak. Created attachment 334690 [details]
Patch for landing
Comment on attachment 334690 [details] Patch for landing Clearing flags on attachment: 334690 Committed r229063: <https://trac.webkit.org/changeset/229063> |