Summary: | [WebKit] Fix Clang unused parameter warnings of NetworkProcess | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebKit Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | achristensen, ap, cdumez, cgarcia, commit-queue, don.olmstead, ews-watchlist, koivisto, mcatanzaro, rniwa, youennf, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 145121 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2018-02-23 03:05:38 PST
Created attachment 334513 [details]
warning messages
Created attachment 334514 [details]
Patch
Comment on attachment 334514 [details]
Patch
r=me
Comment on attachment 334514 [details]
Patch
No, we agreed to build WebKit2 without -Wunused-parameter. (For better or for worse; I actually like that warning.)
Fujii, why are you getting these warnings in your build? It should be suppressed by this block in Source/WebKit/CMakeLists.txt:
if (COMPILER_IS_GCC_OR_CLANG)
WEBKIT_ADD_TARGET_CXX_FLAGS(WebKit -Wno-unused-parameter)
WEBKIT_ADD_TARGET_CXX_FLAGS(WebProcess -Wno-unused-parameter)
WEBKIT_ADD_TARGET_CXX_FLAGS(NetworkProcess -Wno-unused-parameter)
WEBKIT_ADD_TARGET_CXX_FLAGS(StorageProcess -Wno-unused-parameter)
endif ()
(In reply to Michael Catanzaro from comment #4) > Comment on attachment 334514 [details] > Patch > > No, we agreed to build WebKit2 without -Wunused-parameter. (For better or > for worse; I actually like that warning.) > > Fujii, why are you getting these warnings in your build? It should be > suppressed by this block in Source/WebKit/CMakeLists.txt: > > if (COMPILER_IS_GCC_OR_CLANG) > WEBKIT_ADD_TARGET_CXX_FLAGS(WebKit -Wno-unused-parameter) > WEBKIT_ADD_TARGET_CXX_FLAGS(WebProcess -Wno-unused-parameter) > WEBKIT_ADD_TARGET_CXX_FLAGS(NetworkProcess -Wno-unused-parameter) > WEBKIT_ADD_TARGET_CXX_FLAGS(StorageProcess -Wno-unused-parameter) > endif () Oh, I didn't know that WebKit2 has a special rule for this. Thank you. Thank you, Michael and Yusuke. I tried again, but can't reproduce the compilation warnings anymore. There might be something wrong in my env. Closed as invalid. (In reply to Yusuke Suzuki from comment #6) > Oh, I didn't know that WebKit2 has a special rule for this. Thank you. Actually, many of our subprojects use -Wno-unused-parameter, e.g. in Tools. It's not just Source/WebKit. I don't like the inconsistency, but that's the status quo. |