Bug 183055

Summary:

CacheStorage::Engine::Caches::writeRecord is not always calling the completion handler

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, cgarcia, commit-queue, ews-watchlist, koivisto, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2018-02-22 12:47:38 PST

CacheStorage::Engine::Caches::writeRecord is not always calling the completion handler

Comment 1 youenn fablet 2018-02-22 12:52:57 PST

We should really move all CacheStorage callbacks to CompletionHandler to catch these potential issues.
In the meantime, there is an issue with Caches::writeRecord in private browsing mode and when network cache is not calling back the blob.

Comment 2 youenn fablet 2018-02-22 13:13:55 PST

Created attachment 334471 [details]
Patch

Comment 3 WebKit Commit Bot 2018-02-22 14:50:24 PST

Comment on attachment 334471 [details]
Patch

Clearing flags on attachment: 334471

Committed r228935: <https://trac.webkit.org/changeset/228935>

Comment 4 WebKit Commit Bot 2018-02-22 14:50:26 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-02-22 14:51:33 PST

<rdar://problem/37803382>