| Summary: | [RenderTreeBuilder] Move RenderObject::insertedInto() mutation logic to RenderTreeBuilder | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> |
| Component: | Layout and Rendering | Assignee: | zalan <zalan> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
zalan
2018-02-21 15:42:38 PST
Created attachment 334421 [details]
Patch
Comment on attachment 334421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334421&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:390 > while (beforeChild && beforeChild->parent() && beforeChild->parent() != &parent) > - beforeChild = beforeChild->parent(); > + beforeChild = beforeChild->parent(); lol Comment on attachment 334421 [details] Patch Attachment 334421 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6615835 New failing tests: imported/blink/fast/multicol/span/spanner-with-relpos-child.html fast/multicol/span/list-multi-column-crash.html imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html fast/multicol/column-span-range-crash.html fast/multicol/float-not-removed-crash.html imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html fast/multicol/multicol-crazy-nesting.html imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html fast/multicol/newmulticol/spanner-crash.html imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html imported/blink/fast/multicol/span/as-inner-multicol.html Created attachment 334425 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 334421 [details] Patch Attachment 334421 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6615833 New failing tests: imported/blink/fast/multicol/span/spanner-with-relpos-child.html fast/multicol/span/list-multi-column-crash.html imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html fast/multicol/column-span-range-crash.html fast/multicol/float-not-removed-crash.html imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html fast/multicol/multicol-crazy-nesting.html imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html fast/multicol/newmulticol/spanner-crash.html imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html imported/blink/fast/multicol/span/as-inner-multicol.html Created attachment 334427 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 334421 [details] Patch Attachment 334421 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6616002 New failing tests: imported/blink/fast/multicol/span/spanner-with-relpos-child.html fast/multicol/span/list-multi-column-crash.html imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html fast/multicol/column-span-range-crash.html fast/multicol/float-not-removed-crash.html imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html fast/multicol/multicol-crazy-nesting.html imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html fast/multicol/newmulticol/spanner-crash.html imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html imported/blink/fast/multicol/span/as-inner-multicol.html Created attachment 334428 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 334421 [details] Patch Attachment 334421 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6616305 New failing tests: imported/blink/fast/multicol/span/spanner-with-relpos-child.html fast/multicol/span/list-multi-column-crash.html imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html fast/multicol/column-span-range-crash.html fast/multicol/float-not-removed-crash.html imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html fast/dynamic/continuation-detach-crash.html imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html fast/multicol/newmulticol/spanner-crash.html imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html imported/blink/fast/multicol/span/as-inner-multicol.html fast/multicol/multicol-crazy-nesting.html Created attachment 334431 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 334421 [details] Patch Attachment 334421 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6616096 New failing tests: imported/blink/fast/multicol/span/spanner-with-relpos-child.html fast/multicol/span/list-multi-column-crash.html imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html fast/multicol/column-span-range-crash.html fast/multicol/float-not-removed-crash.html imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html fast/multicol/multicol-crazy-nesting.html imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html fast/multicol/newmulticol/spanner-crash.html imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html imported/blink/fast/multicol/span/as-inner-multicol.html Created attachment 334432 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 334421 [details] Patch Attachment 334421 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6616999 New failing tests: imported/blink/fast/multicol/span/spanner-with-relpos-child.html fast/multicol/span/list-multi-column-crash.html imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html fast/multicol/column-span-range-crash.html fast/multicol/float-not-removed-crash.html imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html fast/dynamic/continuation-detach-crash.html imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html fast/multicol/newmulticol/spanner-crash.html imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html imported/blink/fast/multicol/span/as-inner-multicol.html fast/multicol/multicol-crazy-nesting.html Created attachment 334434 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 334421 [details] Patch Attachment 334421 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6616908 New failing tests: imported/blink/fast/multicol/span/spanner-with-relpos-child.html fast/multicol/span/list-multi-column-crash.html imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html fast/multicol/column-span-range-crash.html fast/multicol/float-not-removed-crash.html imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html fast/multicol/multicol-crazy-nesting.html imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html fast/multicol/newmulticol/spanner-crash.html imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html imported/blink/fast/multicol/span/as-inner-multicol.html Created attachment 334435 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 334438 [details]
Patch
Comment on attachment 334438 [details] Patch Clearing flags on attachment: 334438 Committed r228914: <https://trac.webkit.org/changeset/228914> All reviewed patches have been landed. Closing bug. |