Bug 183022 - [RenderTreeBuilder] Move RenderObject::insertedInto() mutation logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderObject::insertedInto() mutation logic to Rende...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-21 15:42 PST by zalan
Modified: 2018-02-21 22:17 PST (History)
8 users (show)

See Also:


Attachments
Patch (6.30 KB, patch)
2018-02-21 15:46 PST, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (3.05 MB, application/zip)
2018-02-21 16:57 PST, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (3.96 MB, application/zip)
2018-02-21 17:14 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.02 MB, application/zip)
2018-02-21 17:20 PST, Build Bot
no flags Details
Archive of layout-test-results from ews201 for win-future (11.50 MB, application/zip)
2018-02-21 18:12 PST, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (42.60 MB, application/zip)
2018-02-21 18:15 PST, Build Bot
no flags Details
Archive of layout-test-results from ews200 for win-future (11.62 MB, application/zip)
2018-02-21 20:03 PST, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (42.15 MB, application/zip)
2018-02-21 20:17 PST, Build Bot
no flags Details
Patch (6.24 KB, patch)
2018-02-21 21:26 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-21 15:42:38 PST
ssia.
Comment 1 Radar WebKit Bug Importer 2018-02-21 15:43:02 PST
<rdar://problem/37764326>
Comment 2 zalan 2018-02-21 15:46:26 PST
Created attachment 334421 [details]
Patch
Comment 3 Antti Koivisto 2018-02-21 15:53:09 PST
Comment on attachment 334421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334421&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:390
>      while (beforeChild && beforeChild->parent() && beforeChild->parent() != &parent)
> -    beforeChild = beforeChild->parent();
> +        beforeChild = beforeChild->parent();

lol
Comment 4 Build Bot 2018-02-21 16:57:49 PST
Comment on attachment 334421 [details]
Patch

Attachment 334421 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6615835

New failing tests:
imported/blink/fast/multicol/span/spanner-with-relpos-child.html
fast/multicol/span/list-multi-column-crash.html
imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html
imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html
fast/multicol/column-span-range-crash.html
fast/multicol/float-not-removed-crash.html
imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html
imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html
fast/multicol/multicol-crazy-nesting.html
imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html
fast/multicol/newmulticol/spanner-crash.html
imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html
imported/blink/fast/multicol/span/as-inner-multicol.html
Comment 5 Build Bot 2018-02-21 16:57:50 PST
Created attachment 334425 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Build Bot 2018-02-21 17:14:03 PST
Comment on attachment 334421 [details]
Patch

Attachment 334421 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6615833

New failing tests:
imported/blink/fast/multicol/span/spanner-with-relpos-child.html
fast/multicol/span/list-multi-column-crash.html
imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html
imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html
fast/multicol/column-span-range-crash.html
fast/multicol/float-not-removed-crash.html
imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html
imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html
fast/multicol/multicol-crazy-nesting.html
imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html
fast/multicol/newmulticol/spanner-crash.html
imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html
imported/blink/fast/multicol/span/as-inner-multicol.html
Comment 7 Build Bot 2018-02-21 17:14:04 PST
Created attachment 334427 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 Build Bot 2018-02-21 17:20:52 PST
Comment on attachment 334421 [details]
Patch

Attachment 334421 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6616002

New failing tests:
imported/blink/fast/multicol/span/spanner-with-relpos-child.html
fast/multicol/span/list-multi-column-crash.html
imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html
imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html
fast/multicol/column-span-range-crash.html
fast/multicol/float-not-removed-crash.html
imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html
imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html
fast/multicol/multicol-crazy-nesting.html
imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html
fast/multicol/newmulticol/spanner-crash.html
imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html
imported/blink/fast/multicol/span/as-inner-multicol.html
Comment 9 Build Bot 2018-02-21 17:20:54 PST
Created attachment 334428 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 10 Build Bot 2018-02-21 18:12:17 PST
Comment on attachment 334421 [details]
Patch

Attachment 334421 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6616305

New failing tests:
imported/blink/fast/multicol/span/spanner-with-relpos-child.html
fast/multicol/span/list-multi-column-crash.html
imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html
imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html
fast/multicol/column-span-range-crash.html
fast/multicol/float-not-removed-crash.html
imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html
imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html
fast/dynamic/continuation-detach-crash.html
imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html
fast/multicol/newmulticol/spanner-crash.html
imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html
imported/blink/fast/multicol/span/as-inner-multicol.html
fast/multicol/multicol-crazy-nesting.html
Comment 11 Build Bot 2018-02-21 18:12:27 PST
Created attachment 334431 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 12 Build Bot 2018-02-21 18:15:28 PST
Comment on attachment 334421 [details]
Patch

Attachment 334421 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6616096

New failing tests:
imported/blink/fast/multicol/span/spanner-with-relpos-child.html
fast/multicol/span/list-multi-column-crash.html
imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html
imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html
fast/multicol/column-span-range-crash.html
fast/multicol/float-not-removed-crash.html
imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html
imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html
fast/multicol/multicol-crazy-nesting.html
imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html
fast/multicol/newmulticol/spanner-crash.html
imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html
imported/blink/fast/multicol/span/as-inner-multicol.html
Comment 13 Build Bot 2018-02-21 18:15:31 PST
Created attachment 334432 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 14 Build Bot 2018-02-21 20:03:02 PST
Comment on attachment 334421 [details]
Patch

Attachment 334421 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6616999

New failing tests:
imported/blink/fast/multicol/span/spanner-with-relpos-child.html
fast/multicol/span/list-multi-column-crash.html
imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html
imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html
fast/multicol/column-span-range-crash.html
fast/multicol/float-not-removed-crash.html
imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html
imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html
fast/dynamic/continuation-detach-crash.html
imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html
fast/multicol/newmulticol/spanner-crash.html
imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html
imported/blink/fast/multicol/span/as-inner-multicol.html
fast/multicol/multicol-crazy-nesting.html
Comment 15 Build Bot 2018-02-21 20:03:12 PST
Created attachment 334434 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 16 Build Bot 2018-02-21 20:17:19 PST
Comment on attachment 334421 [details]
Patch

Attachment 334421 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6616908

New failing tests:
imported/blink/fast/multicol/span/spanner-with-relpos-child.html
fast/multicol/span/list-multi-column-crash.html
imported/blink/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html
imported/blink/fast/multicol/span/relpos-spanner-with-abspos-child.html
fast/multicol/column-span-range-crash.html
fast/multicol/float-not-removed-crash.html
imported/blink/fast/multicol/span/in-nested-multicol-with-list-item.html
imported/blink/fast/multicol/dynamic/remove-content-before-inner-multicol-with-spanner-crash.html
fast/multicol/multicol-crazy-nesting.html
imported/blink/fast/multicol/dynamic/insert-spanner-after-spanner-with-inner-multicol-with-spanner-crash.html
fast/multicol/newmulticol/spanner-crash.html
imported/blink/fast/multicol/span/as-inner-multicol-after-composited-layer-crash.html
imported/blink/fast/multicol/span/as-inner-multicol.html
Comment 17 Build Bot 2018-02-21 20:17:21 PST
Created attachment 334435 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 18 zalan 2018-02-21 21:26:23 PST
Created attachment 334438 [details]
Patch
Comment 19 WebKit Commit Bot 2018-02-21 22:17:50 PST
Comment on attachment 334438 [details]
Patch

Clearing flags on attachment: 334438

Committed r228914: <https://trac.webkit.org/changeset/228914>
Comment 20 WebKit Commit Bot 2018-02-21 22:17:52 PST
All reviewed patches have been landed.  Closing bug.