Bug 183021

Summary: AX: AOM: Dispatch accessiblesetvalue event
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, n_wang, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=169090
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch none

Nan Wang
Reported 2018-02-21 15:40:29 PST
Spec: https://wicg.github.io/aom/spec/phase2.html Support new event type: interface AccessibleSetValueEvent : Event { attribute DOMString value; };
Attachments
patch (25.88 KB, patch)
2018-02-28 12:45 PST, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (26.90 KB, patch)
2018-02-28 13:46 PST, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (26.03 KB, patch)
2018-02-28 14:16 PST, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (26.95 KB, patch)
2018-02-28 15:13 PST, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-21 15:40:58 PST
<rdar://problem/37764242>
Nan Wang
Comment 2 2018-02-28 12:45:50 PST
Created attachment 334758 [details] patch
chris fleizach
Comment 3 2018-02-28 13:01:29 PST
Comment on attachment 334758 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=334758&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2172 > + if (!canSetValueAttribute()) do you think we want to check this here? are there going to be cases where this doesn't match up? technically nothing stopping someone from responding to a set value event on any element right? > Source/WebCore/accessibility/events/AccessibleSetValueEvent.cpp:40 > +{ seems like this should just be in the header
Nan Wang
Comment 4 2018-02-28 13:07:28 PST
Comment on attachment 334758 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=334758&action=review >> Source/WebCore/accessibility/AccessibilityObject.cpp:2172 >> + if (!canSetValueAttribute()) > > do you think we want to check this here? are there going to be cases where this doesn't match up? technically nothing stopping someone from responding to a set value event on any element right? I did this because from the spec this event is limited to some roles: "combobox", "scrollbar", "slider", "textbox"
Nan Wang
Comment 5 2018-02-28 13:07:40 PST
working on fixing the builds
Nan Wang
Comment 6 2018-02-28 13:46:34 PST
Created attachment 334764 [details] patch update
Nan Wang
Comment 7 2018-02-28 14:16:06 PST
Created attachment 334769 [details] patch Tried to fix the build
Nan Wang
Comment 8 2018-02-28 15:13:10 PST
Created attachment 334774 [details] patch Updated test to account for canSetValueAttribute()
WebKit Commit Bot
Comment 9 2018-02-28 16:30:13 PST
Comment on attachment 334774 [details] patch Clearing flags on attachment: 334774 Committed r229112: <https://trac.webkit.org/changeset/229112>
WebKit Commit Bot
Comment 10 2018-02-28 16:30:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.