Summary: | Web Inspector: Canvas tab: ensure that the Recording TreeOutline has a specified height for virtualization | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 174968, 182667 | ||||||||
Bug Blocks: | 175485 | ||||||||
Attachments: |
|
Description
Devin Rousso
2018-02-21 13:20:06 PST
Created attachment 334409 [details]
Patch
Comment on attachment 334409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334409&action=review r-, because it looks like this breaks the recording tree outline: 1. Goto https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_animations 2. Record frames from "a looping panorama" demo 3. Open recording, expand first frame => No child elements > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:716 > + if (!isNaN(this._virtualizedPreviousFirstItem) && Math.abs(firstItem - this._virtualizedPreviousFirstItem) < numberVisible) Why is this needed? The bug title/summary gives the impression that the problem is with how TreeOutline is used in the CanvasSidebarPanel, not with TreeOutline itself. Please add a clarifying comment to the change log. Comment on attachment 334409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334409&action=review >> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:716 >> + if (!isNaN(this._virtualizedPreviousFirstItem) && Math.abs(firstItem - this._virtualizedPreviousFirstItem) < numberVisible) > > Why is this needed? The bug title/summary gives the impression that the problem is with how TreeOutline is used in the CanvasSidebarPanel, not with TreeOutline itself. Please add a clarifying comment to the change log. This is what caused the breakage. I was trying to optimize the virtualization functionality, but I see that it needs some tweaking. :P Created attachment 335208 [details]
Patch
Comment on attachment 335208 [details]
Patch
r=me
Comment on attachment 335208 [details] Patch Clearing flags on attachment: 335208 Committed r229377: <https://trac.webkit.org/changeset/229377> All reviewed patches have been landed. Closing bug. |