Bug 183014

Summary:

[RenderTreeBuilder] Move RenderBoxModelObject::willBeRemoved() mutation logic to RenderTreeBuilder

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2018-02-21 12:56:03 PST

continuation cleanup.

Comment 1 Radar WebKit Bug Importer 2018-02-21 12:56:27 PST

<rdar://problem/37757428>

Comment 2 zalan 2018-02-21 13:35:23 PST

Created attachment 334410 [details]
Patch

Comment 3 Antti Koivisto 2018-02-21 13:38:09 PST

Comment on attachment 334410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334410&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderContinuation.h:34
> +class RenderTreeBuilder::Continuation {

This (and others) could have WTF_MAKE_FAST_ALLOCATED

Comment 4 zalan 2018-02-21 14:03:17 PST

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 334410 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334410&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeBuilderContinuation.h:34
> > +class RenderTreeBuilder::Continuation {
> 
> This (and others) could have WTF_MAKE_FAST_ALLOCATED
Indeed. I'll address it in a separate patch.

Comment 5 WebKit Commit Bot 2018-02-21 14:27:05 PST

Comment on attachment 334410 [details]
Patch

Clearing flags on attachment: 334410

Committed r228899: <https://trac.webkit.org/changeset/228899>

Comment 6 WebKit Commit Bot 2018-02-21 14:27:06 PST

All reviewed patches have been landed.  Closing bug.