Bug 183014

Summary: [RenderTreeBuilder] Move RenderBoxModelObject::willBeRemoved() mutation logic to RenderTreeBuilder
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2018-02-21 12:56:03 PST
continuation cleanup.
Attachments
Patch (17.36 KB, patch)
2018-02-21 13:35 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-21 12:56:27 PST
<rdar://problem/37757428>
alan
Comment 2 2018-02-21 13:35:23 PST
Created attachment 334410 [details] Patch
Antti Koivisto
Comment 3 2018-02-21 13:38:09 PST
Comment on attachment 334410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334410&action=review > Source/WebCore/rendering/updating/RenderTreeBuilderContinuation.h:34 > +class RenderTreeBuilder::Continuation { This (and others) could have WTF_MAKE_FAST_ALLOCATED
alan
Comment 4 2018-02-21 14:03:17 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 334410 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334410&action=review > > > Source/WebCore/rendering/updating/RenderTreeBuilderContinuation.h:34 > > +class RenderTreeBuilder::Continuation { > > This (and others) could have WTF_MAKE_FAST_ALLOCATED Indeed. I'll address it in a separate patch.
WebKit Commit Bot
Comment 5 2018-02-21 14:27:05 PST
Comment on attachment 334410 [details] Patch Clearing flags on attachment: 334410 Committed r228899: <https://trac.webkit.org/changeset/228899>
WebKit Commit Bot
Comment 6 2018-02-21 14:27:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.