Bug 183014 - [RenderTreeBuilder] Move RenderBoxModelObject::willBeRemoved() mutation logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderBoxModelObject::willBeRemoved() mutation logic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-21 12:56 PST by zalan
Modified: 2018-02-21 14:27 PST (History)
6 users (show)

See Also:

Attachments
Patch (17.36 KB, patch)
2018-02-21 13:35 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-21 12:56:03 PST 
continuation cleanup.
Comment 1 Radar WebKit Bug Importer 2018-02-21 12:56:27 PST 
<rdar://problem/37757428>
Comment 2 zalan 2018-02-21 13:35:23 PST 
Created attachment 334410 [details]
Patch
Comment 3 Antti Koivisto 2018-02-21 13:38:09 PST 
Comment on attachment 334410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334410&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderContinuation.h:34
> +class RenderTreeBuilder::Continuation {

This (and others) could have WTF_MAKE_FAST_ALLOCATED
Comment 4 zalan 2018-02-21 14:03:17 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 334410 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334410&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeBuilderContinuation.h:34
> > +class RenderTreeBuilder::Continuation {
> 
> This (and others) could have WTF_MAKE_FAST_ALLOCATED
Indeed. I'll address it in a separate patch.
Comment 5 WebKit Commit Bot 2018-02-21 14:27:05 PST 
Comment on attachment 334410 [details]
Patch

Clearing flags on attachment: 334410

Committed r228899: <https://trac.webkit.org/changeset/228899>
Comment 6 WebKit Commit Bot 2018-02-21 14:27:06 PST 
All reviewed patches have been landed.  Closing bug.