Bug 183012

Summary:

Document.open() cancels existing provisional load but not navigation policy check

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, beidson, commit-queue, dbates, esprehn+autocc, ews-watchlist, japhet, kangil.han, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

180568

Attachments:

Description	Flags
WIP Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews205 for win-future	none
Patch	none

Description Chris Dumez 2018-02-21 12:03:41 PST

Document.open() cancels existing provisional load but not navigation policy check.

Now that policy decision can be made asynchronously, Document.open() can be called while we're awaiting the policy decision for a navigation. However, Document.open() currently only cancels pending provisional loads, after we've received the navigation policy decision. We need to make sure it cancels pending navigation policy decisions as well.

Comment 1 Radar WebKit Bug Importer 2018-02-21 12:04:06 PST

<rdar://problem/37755831>

Comment 2 Chris Dumez 2018-02-21 12:05:26 PST

Created attachment 334401 [details]
WIP Patch

Comment 3 EWS Watchlist 2018-02-21 13:10:13 PST

Comment on attachment 334401 [details]
WIP Patch

Attachment 334401 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6612870

New failing tests:
fast/dom/Document/open-with-pending-load-async-policy.html

Comment 4 EWS Watchlist 2018-02-21 13:10:15 PST

Created attachment 334408 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 5 EWS Watchlist 2018-02-21 13:41:08 PST

Comment on attachment 334401 [details]
WIP Patch

Attachment 334401 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6613134

New failing tests:
fast/dom/Document/open-with-pending-load-async-policy.html

Comment 6 EWS Watchlist 2018-02-21 13:41:09 PST

Created attachment 334411 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 7 EWS Watchlist 2018-02-21 14:08:26 PST

Comment on attachment 334401 [details]
WIP Patch

Attachment 334401 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6613647

New failing tests:
fast/dom/Document/open-with-pending-load-async-policy.html

Comment 8 EWS Watchlist 2018-02-21 14:08:37 PST

Created attachment 334412 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 9 Chris Dumez 2018-02-21 14:53:29 PST

Created attachment 334418 [details]
Patch

Comment 10 WebKit Commit Bot 2018-02-22 10:29:31 PST

Comment on attachment 334418 [details]
Patch

Clearing flags on attachment: 334418

Committed r228922: <https://trac.webkit.org/changeset/228922>

Comment 11 WebKit Commit Bot 2018-02-22 10:29:32 PST

All reviewed patches have been landed.  Closing bug.