Bug 183011

Summary: [CMake] Expose HAVE macros globally
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, lforschler, mcatanzaro, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2018-02-21 11:58:38 PST
Currently all the macros wrapping platform HAVE checks are locally scoped. These should be available in other CMake files.
Attachments
Patch (6.02 KB, patch)
2018-02-21 12:01 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (5.46 KB, patch)
2018-02-21 12:03 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-02-21 12:01:05 PST
Created attachment 334398 [details] Patch
Don Olmstead
Comment 2 2018-02-21 12:03:07 PST
Created attachment 334400 [details] Patch
Don Olmstead
Comment 3 2018-02-21 12:05:53 PST
I am planning on using these changes in https://bugs.webkit.org/show_bug.cgi?id=182891 and figured I'd get this reviewed on its own while I wait for Per Arne to check that WIP patch to make sure it works for Apple's internal windows build.
WebKit Commit Bot
Comment 4 2018-02-21 14:34:06 PST
Comment on attachment 334400 [details] Patch Clearing flags on attachment: 334400 Committed r228900: <https://trac.webkit.org/changeset/228900>
WebKit Commit Bot
Comment 5 2018-02-21 14:34:07 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-02-21 14:35:33 PST
<rdar://problem/37761582>
Konstantin Tokarev
Comment 7 2018-02-22 11:03:41 PST
Comment on attachment 334400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334400&action=review > Source/cmake/OptionsCommon.cmake:119 > +WEBKIT_CHECK_HAVE_INCLUDE(HAVE_FEATURES_H features.h) I think WEBKIT_CHECK_INCLUDE would be a better name
Note You need to log in before you can comment on or make changes to this bug.