[GStreamer] HTTP totalBytes query returns 0 after seeking (sometimes)

• Component: Platform
• Status: RESOLVED FIXED

[Philippe Normand]

The size attribute is reset when the element performs seeks, I don't see why that would make sense. Also it's useless to handle the DURATION query if the appsrc size is correctly set (once) in the first place.

[Philippe Normand]

Created attachment 334375 [details]
Patch

[Enrique Ocaña]

Comment on attachment 334375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334375&action=review

Apart from the nitpick below, I don't see anything wrong with the patch.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:86
> +    gboolean haveSize;

This attribute is only for internal usage and doesn't interact with Glib. Why not using a C++ bool type, like for "paused" or "isSeeking"?

[Xabier Rodríguez Calvar]

Comment on attachment 334375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334375&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:86
>> +    gboolean haveSize;
> 
> This attribute is only for internal usage and doesn't interact with Glib. Why not using a C++ bool type, like for "paused" or "isSeeking"?

I was going to mention exactly the same thing :)

[Philippe Normand]

Committed r228945: <https://trac.webkit.org/changeset/228945>

[Radar WebKit Bug Importer]

<rdar://problem/37820322>