Bug 182958

Summary: [Cairo] Leverage ShadowBlur without using scratch buffer, target GraphicsContext
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-02-19 23:44:41 PST
[Cairo] Leverage ShadowBlur without using scratch buffer, target GraphicsContext
Attachments
Patch (29.48 KB, patch)
2018-02-20 00:37 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.49 KB, patch)
2018-02-20 02:43 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-02-20 00:37:25 PST
Created attachment 334250 [details] Patch
Carlos Garcia Campos
Comment 2 2018-02-20 01:06:30 PST
Comment on attachment 334250 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334250&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:181 > + if (image) { Use an early return here. > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:237 > + (GraphicsContext& shadowContext) Move this to previous line for consistency with other lambdas.
Zan Dobersek
Comment 3 2018-02-20 02:43:35 PST
Created attachment 334256 [details] Patch for landing
Zan Dobersek
Comment 4 2018-02-20 02:52:18 PST
Comment on attachment 334256 [details] Patch for landing Clearing flags on attachment: 334256 Committed r228776: <https://trac.webkit.org/changeset/228776>
Zan Dobersek
Comment 5 2018-02-20 02:52:23 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-02-20 02:59:53 PST
<rdar://problem/37702933>
Note You need to log in before you can comment on or make changes to this bug.