Bug 182957

Summary: Make more use of USE(OPENGL_ES) where it makes sense
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, dino, eric.carlson, jer.noble, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-02-19 23:31:52 PST
Make more use of USE(OPENGL_ES) where it makes sense
Attachments
Patch (13.08 KB, patch)
2018-02-19 23:32 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (13.34 KB, patch)
2018-02-20 12:04 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-02-19 23:32:20 PST
Created attachment 334247 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-02-19 23:37:39 PST
<rdar://problem/37699443>
mitz
Comment 3 2018-02-19 23:42:18 PST
Comment on attachment 334247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334247&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.h:64 > +#else // PLATFORM(COCOA) This is confusing. Maybe just #endif // PLATFORM(COCOA) then #if !PLATFORM(COCOA)? > Source/WebCore/platform/graphics/GraphicsContext3D.h:66 > +#endif // PLATFORM(COCOA) Confusing. > Source/WebCore/platform/graphics/GraphicsContext3D.h:72 > +#else // __OBJC__ Also. > Source/WebCore/platform/graphics/GraphicsContext3D.h:80 > +#else // PLATFORM(COCOA) As well.
Tim Horton
Comment 4 2018-02-19 23:44:54 PST
Interesting! I feel like there was once a webkit-dev debate about this :) No idea how it was resolved, but your solution sounds reasonable to me.
Tim Horton
Comment 5 2018-02-20 12:04:52 PST
Created attachment 334292 [details] Patch
WebKit Commit Bot
Comment 6 2018-02-20 15:34:05 PST
Comment on attachment 334292 [details] Patch Clearing flags on attachment: 334292 Committed r228849: <https://trac.webkit.org/changeset/228849>
WebKit Commit Bot
Comment 7 2018-02-20 15:34:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.