Bug 182947

Summary: [RenderTreeBuilder] Move RenderFullScreen::willBeRemoved() mutation logic to RenderTreeBuilder
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Archive of layout-test-results from ews117 for mac-sierra
none
Patch
none
Patch
none
Patch none

alan
Reported 2018-02-19 16:46:29 PST
ssia
Attachments
Patch (13.79 KB, patch)
2018-02-19 17:17 PST, alan 		koivisto: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.69 MB, application/zip)
2018-02-19 17:55 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.18 MB, application/zip)
2018-02-19 18:27 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews117 for mac-sierra (2.71 MB, application/zip)
2018-02-19 18:48 PST, EWS Watchlist 		no flags
Details
Patch (14.45 KB, patch)
2018-02-19 22:08 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.57 KB, patch)
2018-02-20 21:16 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.88 KB, patch)
2018-02-20 21:43 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-19 16:46:57 PST
<rdar://problem/37690848>
alan
Comment 2 2018-02-19 17:17:34 PST
Created attachment 334207 [details] Patch
EWS Watchlist
Comment 3 2018-02-19 17:55:47 PST
Comment on attachment 334207 [details] Patch Attachment 334207 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6581030 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2018-02-19 17:55:48 PST
Created attachment 334217 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 5 2018-02-19 18:27:02 PST
Comment on attachment 334207 [details] Patch Attachment 334207 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6581641 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6 2018-02-19 18:27:04 PST
Created attachment 334222 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 7 2018-02-19 18:48:16 PST
Comment on attachment 334207 [details] Patch Attachment 334207 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6581759 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 8 2018-02-19 18:48:17 PST
Created attachment 334225 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
alan
Comment 9 2018-02-19 22:08:47 PST
Created attachment 334242 [details] Patch
alan
Comment 10 2018-02-20 21:16:06 PST
Created attachment 334339 [details] Patch
alan
Comment 11 2018-02-20 21:43:19 PST
Created attachment 334340 [details] Patch
WebKit Commit Bot
Comment 12 2018-02-21 00:25:44 PST
Comment on attachment 334340 [details] Patch Clearing flags on attachment: 334340 Committed r228862: <https://trac.webkit.org/changeset/228862>
WebKit Commit Bot
Comment 13 2018-02-21 00:25:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.