Bug 182943

Summary:

[RenderTreeBuilder] Move RenderListItem::willBeRemoved() mutation logic to RenderTreeBuilder

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews114 for mac-sierra	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews201 for win-future	none
Patch	none

alan

Reported 2018-02-19 15:51:01 PST

ssia

Attachments
Patch (3.65 KB, patch) 2018-02-19 15:52 PST, alan	koivisto: review+	Details Formatted Diff Diff
Patch (3.68 KB, patch) 2018-02-19 16:15 PST, alan	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.63 MB, application/zip) 2018-02-19 17:21 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (2.97 MB, application/zip) 2018-02-19 17:35 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.29 MB, application/zip) 2018-02-19 17:44 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews201 for win-future (11.54 MB, application/zip) 2018-02-19 17:59 PST, EWS Watchlist	no flags	Details
Patch (2.35 KB, patch) 2018-02-20 20:00 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-02-19 15:51:34 PST

<rdar://problem/37689029>

alan

Comment 2 2018-02-19 15:52:41 PST

Created attachment 334197 [details] Patch

alan

Comment 3 2018-02-19 16:15:08 PST

Created attachment 334199 [details] Patch

EWS Watchlist

Comment 4 2018-02-19 17:21:36 PST

Comment on attachment 334199 [details] Patch Attachment 334199 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6580346 New failing tests: fast/multicol/newmulticol/change-spanner-display.html

EWS Watchlist

Comment 5 2018-02-19 17:21:37 PST

Created attachment 334208 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-02-19 17:35:46 PST

Comment on attachment 334199 [details] Patch Attachment 334199 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6580008 New failing tests: fast/multicol/newmulticol/change-spanner-display.html

EWS Watchlist

Comment 7 2018-02-19 17:35:47 PST

Created attachment 334209 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-02-19 17:44:36 PST

Comment on attachment 334199 [details] Patch Attachment 334199 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6580466 New failing tests: fast/multicol/newmulticol/change-spanner-display.html

EWS Watchlist

Comment 9 2018-02-19 17:44:38 PST

Created attachment 334214 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-02-19 17:58:45 PST

Comment on attachment 334199 [details] Patch Attachment 334199 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6580890 New failing tests: fast/multicol/newmulticol/change-spanner-display.html

EWS Watchlist

Comment 11 2018-02-19 17:59:17 PST

Created attachment 334218 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

alan

Comment 12 2018-02-20 20:00:15 PST

Created attachment 334337 [details] Patch

WebKit Commit Bot

Comment 13 2018-02-20 20:39:33 PST

Comment on attachment 334337 [details] Patch Clearing flags on attachment: 334337 Committed r228858: <https://trac.webkit.org/changeset/228858>

WebKit Commit Bot

Comment 14 2018-02-20 20:39:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.