Bug 182926

Summary: [RenderTreeBuilder] Remove redundant RenderObject::removeFromParentAndDestroy
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, commit-queue: commit-queue-

alan
Reported 2018-02-19 09:57:27 PST
call removeAndDestroyChild directly instead.
Attachments
Patch (15.97 KB, patch)
2018-02-19 10:02 PST, alan 		koivisto: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-19 09:58:10 PST
<rdar://problem/37674997>
alan
Comment 2 2018-02-19 10:02:27 PST
Created attachment 334162 [details] Patch
WebKit Commit Bot
Comment 3 2018-02-19 10:47:21 PST
Comment on attachment 334162 [details] Patch Rejecting attachment 334162 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334162, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6574637
alan
Comment 4 2018-02-19 11:03:43 PST
Committed r228701: <https://trac.webkit.org/changeset/228701>
Note You need to log in before you can comment on or make changes to this bug.