Bug 182910

Summary:

REGRESSION (r219342): Touch event coordinates and elementFromPoint coordinates differ

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, ajuma, commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews202 for win-future	none
Patch	none
Patch	none

Tim Horton

Reported 2018-02-17 23:05:15 PST

REGRESSION (r219342): Touch event coordinates and elementFromPoint coordinates differ

Attachments
Patch (10.01 KB, patch) 2018-02-17 23:05 PST, Tim Horton	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.21 MB, application/zip) 2018-02-18 00:05 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.57 MB, application/zip) 2018-02-18 00:11 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (2.92 MB, application/zip) 2018-02-18 00:30 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.15 MB, application/zip) 2018-02-18 00:37 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews202 for win-future (11.59 MB, application/zip) 2018-02-18 00:51 PST, EWS Watchlist	no flags	Details
Patch (6.40 KB, patch) 2018-02-19 12:15 PST, Tim Horton	no flags	Details Formatted Diff Diff
Patch (14.45 KB, patch) 2018-02-19 13:22 PST, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2018-02-17 23:05:27 PST

Created attachment 334116 [details] Patch

EWS Watchlist

Comment 2 2018-02-18 00:05:54 PST Comment hidden (obsolete)

Comment on attachment 334116 [details] Patch Attachment 334116 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6559964 New failing tests: fast/dom/elementFromPoint-scaled-scrolled.html

EWS Watchlist

Comment 3 2018-02-18 00:05:55 PST Comment hidden (obsolete)

Created attachment 334117 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-02-18 00:11:37 PST Comment hidden (obsolete)

Comment on attachment 334116 [details] Patch Attachment 334116 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6559991 New failing tests: fast/dom/elementFromPoint-scaled-scrolled.html

EWS Watchlist

Comment 5 2018-02-18 00:11:38 PST Comment hidden (obsolete)

Created attachment 334118 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-02-18 00:30:21 PST Comment hidden (obsolete)

Comment on attachment 334116 [details] Patch Attachment 334116 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6560036 New failing tests: fast/dom/elementFromPoint-scaled-scrolled.html

EWS Watchlist

Comment 7 2018-02-18 00:30:22 PST Comment hidden (obsolete)

Created attachment 334119 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-02-18 00:37:15 PST Comment hidden (obsolete)

Comment on attachment 334116 [details] Patch Attachment 334116 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6560053 New failing tests: fast/dom/elementFromPoint-relative-to-viewport.html fast/dom/elementFromPoint-scaled-scrolled.html

EWS Watchlist

Comment 9 2018-02-18 00:37:16 PST Comment hidden (obsolete)

Created attachment 334120 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-02-18 00:50:39 PST Comment hidden (obsolete)

Comment on attachment 334116 [details] Patch Attachment 334116 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6560321 New failing tests: fast/dom/elementFromPoint-scaled-scrolled.html

EWS Watchlist

Comment 11 2018-02-18 00:51:01 PST Comment hidden (obsolete)

Created attachment 334121 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Simon Fraser (smfr)

Comment 12 2018-02-19 10:43:57 PST

Comment on attachment 334116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334116&action=review > Source/WebCore/ChangeLog:12 > + We reverted other changes to the definition of client coordinates > + in r219829 due to compatibility concerns. However, we failed to revert > + r219342 on trunk, leaving elementFromPoint() using coordinates relative > + to the layout viewport. I think the right thing to do here is to add a settings, like "clientCoordinatesRelativeToLayoutViewport", and make all these changes conditional. Layout-viewport-relative coords are the future, so we should skate etc.

Tim Horton

Comment 13 2018-02-19 10:55:50 PST

(In reply to Simon Fraser (smfr) from comment #12) > Comment on attachment 334116 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334116&action=review > > > Source/WebCore/ChangeLog:12 > > + We reverted other changes to the definition of client coordinates > > + in r219829 due to compatibility concerns. However, we failed to revert > > + r219342 on trunk, leaving elementFromPoint() using coordinates relative > > + to the layout viewport. > > I think the right thing to do here is to add a settings, like > "clientCoordinatesRelativeToLayoutViewport", and make all these changes > conditional. Layout-viewport-relative coords are the future, so we should > skate etc. Agreed, that makes sense. Do you want me to do this for this patch and have the switch only switch elementFromPoint?

Tim Horton

Comment 14 2018-02-19 12:15:08 PST

Created attachment 334174 [details] Patch

Tim Horton

Comment 15 2018-02-19 13:22:17 PST

Created attachment 334180 [details] Patch

WebKit Commit Bot

Comment 16 2018-02-19 15:30:32 PST

Comment on attachment 334180 [details] Patch Clearing flags on attachment: 334180 Committed r228714: <https://trac.webkit.org/changeset/228714>

WebKit Commit Bot

Comment 17 2018-02-19 15:30:35 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2018-02-19 15:32:33 PST

<rdar://problem/37688387>

Note You need to log in before you can comment on or make changes to this bug.