Bug 182885

Summary: [RenderTreeBuilder] Move RenderElement::insertChildInternal() to RenderTreeBuilder
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch
none
Patch none

Description zalan 2018-02-16 13:50:55 PST
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-16 13:51:28 PST
<rdar://problem/37617371>
Comment 2 zalan 2018-02-16 14:08:56 PST
Created attachment 334068 [details]
Patch
Comment 3 zalan 2018-02-16 14:46:34 PST
Created attachment 334074 [details]
Patch
Comment 4 WebKit Commit Bot 2018-02-16 15:24:32 PST
Comment on attachment 334074 [details]
Patch

Rejecting attachment 334074 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 334074, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/6543501
Comment 5 zalan 2018-02-16 15:29:11 PST
Created attachment 334079 [details]
Patch
Comment 6 WebKit Commit Bot 2018-02-16 16:05:38 PST
Comment on attachment 334079 [details]
Patch

Clearing flags on attachment: 334079

Committed r228588: <https://trac.webkit.org/changeset/228588>
Comment 7 WebKit Commit Bot 2018-02-16 16:05:40 PST
All reviewed patches have been landed.  Closing bug.