Bug 182885 - [RenderTreeBuilder] Move RenderElement::insertChildInternal() to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderElement::insertChildInternal() to RenderTreeBu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-16 13:50 PST by zalan
Modified: 2018-02-16 16:05 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.98 KB, patch)
2018-02-16 14:08 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff
Patch (15.62 KB, patch)
2018-02-16 14:46 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (15.58 KB, patch)
2018-02-16 15:29 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-16 13:50:55 PST
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-16 13:51:28 PST
<rdar://problem/37617371>
Comment 2 zalan 2018-02-16 14:08:56 PST
Created attachment 334068 [details]
Patch
Comment 3 zalan 2018-02-16 14:46:34 PST
Created attachment 334074 [details]
Patch
Comment 4 WebKit Commit Bot 2018-02-16 15:24:32 PST
Comment on attachment 334074 [details]
Patch

Rejecting attachment 334074 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 334074, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/6543501
Comment 5 zalan 2018-02-16 15:29:11 PST
Created attachment 334079 [details]
Patch
Comment 6 WebKit Commit Bot 2018-02-16 16:05:38 PST
Comment on attachment 334079 [details]
Patch

Clearing flags on attachment: 334079

Committed r228588: <https://trac.webkit.org/changeset/228588>
Comment 7 WebKit Commit Bot 2018-02-16 16:05:40 PST
All reviewed patches have been landed.  Closing bug.