Bug 182877

Summary: [Extra zoom mode] Form control values are stale after dismissing and representing input view controllers
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix non-iOS builds
none
ChangeLog tweaks.
thorton: review+
Patch for landing none

Description Wenson Hsieh 2018-02-16 09:50:34 PST
<rdar://problem/37604395>
Comment 1 Wenson Hsieh 2018-02-17 15:35:48 PST
Created attachment 334110 [details]
Patch
Comment 2 Wenson Hsieh 2018-02-17 15:45:55 PST
Created attachment 334111 [details]
Fix non-iOS builds
Comment 3 Wenson Hsieh 2018-02-17 17:35:40 PST
Created attachment 334112 [details]
ChangeLog tweaks.
Comment 4 Tim Horton 2018-02-17 20:17:04 PST
Comment on attachment 334112 [details]
ChangeLog tweaks.

View in context: https://bugs.webkit.org/attachment.cgi?id=334112&action=review

> Source/WebKit/Shared/AssistedNodeInformation.h:117
> +    unsigned assistedNodeIdentifier { 0 };

maybe a sized type? We usually use uint64 for IDs
Comment 5 Wenson Hsieh 2018-02-17 20:58:48 PST
Comment on attachment 334112 [details]
ChangeLog tweaks.

View in context: https://bugs.webkit.org/attachment.cgi?id=334112&action=review

Thanks for the review!

>> Source/WebKit/Shared/AssistedNodeInformation.h:117
>> +    unsigned assistedNodeIdentifier { 0 };
> 
> maybe a sized type? We usually use uint64 for IDs

Got it — changed to a `uint64_t` instead.
Comment 6 Wenson Hsieh 2018-02-17 21:14:36 PST
Created attachment 334114 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-02-17 21:50:19 PST
Comment on attachment 334114 [details]
Patch for landing

Clearing flags on attachment: 334114

Committed r228602: <https://trac.webkit.org/changeset/228602>