Bug 182876

Summary: [RenderTreeBuilder] Move RenderBlock/RenderInline::addChildIgnoringContinuation() to RenderTreeBuilder
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch commit-queue: commit-queue-

zalan
Reported 2018-02-16 09:24:41 PST
ssia
Attachments
Patch (16.44 KB, patch)
2018-02-16 09:33 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (16.42 KB, patch)
2018-02-16 10:37 PST, zalan 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-16 09:25:02 PST
<rdar://problem/37607604>
zalan
Comment 2 2018-02-16 09:33:34 PST
Created attachment 334046 [details] Patch
WebKit Commit Bot
Comment 3 2018-02-16 10:29:28 PST
Comment on attachment 334046 [details] Patch Rejecting attachment 334046 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334046, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6538597
zalan
Comment 4 2018-02-16 10:37:29 PST
Created attachment 334051 [details] Patch
WebKit Commit Bot
Comment 5 2018-02-16 12:39:20 PST
Comment on attachment 334051 [details] Patch Rejecting attachment 334051 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 334051, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: at 525 (offset 2 lines). patching file Source/WebCore/rendering/updating/RenderTreeBuilder.h Hunk #2 FAILED at 65. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/updating/RenderTreeBuilder.h.rej patching file Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp patching file Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/6540701
zalan
Comment 6 2018-02-16 13:42:45 PST
Committed r228578: <https://trac.webkit.org/changeset/228578>
Note You need to log in before you can comment on or make changes to this bug.