Bug 182876 - [RenderTreeBuilder] Move RenderBlock/RenderInline::addChildIgnoringContinuation() to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderBlock/RenderInline::addChildIgnoringContinuati...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-16 09:24 PST by zalan
Modified: 2018-02-16 13:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.44 KB, patch)
2018-02-16 09:33 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (16.42 KB, patch)
2018-02-16 10:37 PST, zalan 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-16 09:24:41 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-16 09:25:02 PST 
<rdar://problem/37607604>
Comment 2 zalan 2018-02-16 09:33:34 PST 
Created attachment 334046 [details]
Patch
Comment 3 WebKit Commit Bot 2018-02-16 10:29:28 PST 
Comment on attachment 334046 [details]
Patch

Rejecting attachment 334046 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334046, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://webkit-queues.webkit.org/results/6538597
Comment 4 zalan 2018-02-16 10:37:29 PST 
Created attachment 334051 [details]
Patch
Comment 5 WebKit Commit Bot 2018-02-16 12:39:20 PST 
Comment on attachment 334051 [details]
Patch

Rejecting attachment 334051 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 334051, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 at 525 (offset 2 lines).
patching file Source/WebCore/rendering/updating/RenderTreeBuilder.h
Hunk #2 FAILED at 65.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/updating/RenderTreeBuilder.h.rej
patching file Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
patching file Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6540701
Comment 6 zalan 2018-02-16 13:42:45 PST 
Committed r228578: <https://trac.webkit.org/changeset/228578>