Bug 182870

Summary: [WinCairo] Fix compile errors of WebProcess and NetworkProcess due to no implementation for windows
Product: WebKit Reporter: Yousuke Kimoto <Yousuke.Kimoto>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: achristensen, ap, beidson, cdumez, commit-queue, darin, don.olmstead, koivisto, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174003    
Description Flags
bz182870-1.patch none

Description Yousuke Kimoto 2018-02-16 05:29:34 PST
Some WebKit sources of WebProcess and NetworkProcess don't have appropriate implementation for the windows port, so many compile errors occur.
This ticket solves this issue which comes from the following files:
- Source/WebKit/NetworkProcess/NetworkProcess.cpp
- Source/WebKit/WebProcess/Plugins/PluginProcessConnectionManager.cpp
- Source/WebKit/WebProcess/WebPage/WebInspector.cpp
- Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp
- Source/WebKit/WebProcess/WebProcess.cpp
Comment 1 Yousuke Kimoto 2018-02-16 05:39:58 PST
Created attachment 334037 [details]
Comment 2 WebKit Commit Bot 2018-02-21 13:41:11 PST
Comment on attachment 334037 [details]

Clearing flags on attachment: 334037

Committed r228893: <https://trac.webkit.org/changeset/228893>
Comment 3 WebKit Commit Bot 2018-02-21 13:41:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-02-21 13:44:24 PST
Comment 5 Chris Dumez 2018-02-21 14:19:47 PST
Was there discussion on the mailing list about adding support for Windows to WebKit2?