Bug 182859

Summary: REGRESSION (r220112): reCAPTCHA images render off screen on Twitch.tv app Log In or Sign Up
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
zalan: review+
patch none

Description zalan 2018-02-15 21:28:06 PST
The web interface for logging in with the twitch app is unusable. The captcha they used to authenticate login renders offscreen and the button is cropped so you cannot click on it
https://itunes.apple.com/app/id460177396?mt=8
Comment 1 Radar WebKit Bug Importer 2018-02-15 21:28:39 PST
<rdar://problem/37595065>
Comment 2 zalan 2018-02-15 21:35:11 PST
Need to figure out how Twitch.tv depends on frame flatting sizing and why puts the image offscreen when only the first (desktop size) size is reported. see https://trac.webkit.org/changeset/220112/webkit
Comment 3 Radar WebKit Bug Importer 2018-02-15 21:35:35 PST
<rdar://problem/37595129>
Comment 4 Antti Koivisto 2018-04-23 15:25:59 PDT
*** Bug 184898 has been marked as a duplicate of this bug. ***
Comment 5 Antti Koivisto 2018-04-23 15:27:58 PDT
Created attachment 338609 [details]
patch
Comment 6 Antti Koivisto 2018-04-23 15:58:13 PDT
Created attachment 338612 [details]
patch
Comment 7 WebKit Commit Bot 2018-04-23 17:13:21 PDT
Comment on attachment 338612 [details]
patch

Clearing flags on attachment: 338612

Committed r230933: <https://trac.webkit.org/changeset/230933>
Comment 8 WebKit Commit Bot 2018-04-23 17:13:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Darin Adler 2018-04-26 21:34:20 PDT
I understand why we removed the fix if it’s no longer needed, but why remove the test?
Comment 10 Antti Koivisto 2018-04-27 03:27:34 PDT
The test is for specific behavior (to break media query listener/document mutation cycle) introduced in this patch. It is not obvious to me how to modify it and to keep it still useful.