Bug 182841

Summary: Speed up dSYM generation on build.webkit.org with -gline-tables-only
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, fpizlo, jlewis3, lforschler, mitz, ryanhaddad
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2018-02-15 14:31:09 PST
We need to produce dSYM files on CI builders to have line numbers in crash logs on testers. On my machine, a full release build of WebKit with dSYM generation takes ~6 minutes longer than without (the time is split between slower compilation and slower dsymutil invocations). With -gline-tables-only AKA -gmlt, the cost is only 30 seconds, and the resulting dSYMs are also dramatically smaller (962 MB to 139 MB for WebCore). I believe that we would be getting proper crash logs with -gline-tables-only too.
Attachments
proposed patch (2.35 KB, patch)
2018-02-15 14:43 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-02-15 14:42:47 PST
rdar://problem/34579649
Alexey Proskuryakov
Comment 2 2018-02-15 14:43:05 PST
Created attachment 333951 [details] proposed patch
Aakash Jain
Comment 3 2018-02-15 15:48:32 PST
Comment on attachment 333951 [details] proposed patch Seems fine to me.
WebKit Commit Bot
Comment 4 2018-02-15 16:07:28 PST
Comment on attachment 333951 [details] proposed patch Clearing flags on attachment: 333951 Committed r228539: <https://trac.webkit.org/changeset/228539>
WebKit Commit Bot
Comment 5 2018-02-15 16:07:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.