| Summary: | imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-* LayoutTests are flaky failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | New Bugs | Assignee: | Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aboya, clopez, commit-queue, dino, ews-watchlist, jlewis3, Ms2ger, rniwa, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Ryan Haddad
2018-02-15 11:07:00 PST
Updated TestExpectations for macOS in https://trac.webkit.org/r228526 Same error on GTK, but more frequently. Moved TestExpectations to base (multiplatform) file. https://trac.webkit.org/changeset/230034/webkit *** Bug 184562 has been marked as a duplicate of this bug. *** The problem here is that the video element sometimes doesn't load. I've been debugging, but haven't found the cause yet. Created attachment 338096 [details]
Patch
The failure that happened at least one every hundred runs before this change, didn't occur in >1000 runs after the change. Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7342418 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html Created attachment 338099 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7342423 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html Created attachment 338100 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7342444 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html Created attachment 338101 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7342451 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html Created attachment 338102 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 338104 [details]
Patch
Comment on attachment 338104 [details] Patch Attachment 338104 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7343576 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html Created attachment 338111 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 338199 [details]
Patch
Comment on attachment 338199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338199&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + * web-platform-tests/2dcontext/imagebitmap/common.sub.js: ensure event handlers aren't garbage collected > + * web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub-expected.txt: update expectations Which one is the policy for updating this tests (not the expectation, but the test itself) ?? Shouldn't we send a PR to https://github.com/w3c/web-platform-tests ? (In reply to Carlos Alberto Lopez Perez from comment #20) > Comment on attachment 338199 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338199&action=review > > > LayoutTests/imported/w3c/ChangeLog:9 > > + * web-platform-tests/2dcontext/imagebitmap/common.sub.js: ensure event handlers aren't garbage collected > > + * web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub-expected.txt: update expectations > > Which one is the policy for updating this tests (not the expectation, but > the test itself) ?? > Shouldn't we send a PR to https://github.com/w3c/web-platform-tests ? I will push the change upstream as soon as it has review here. (The wpt review policy just requires a review in some public place, to make this use case possible.) Comment on attachment 338199 [details]
Patch
r=me
but please submit this changes on the tests to WPT and update this bug with a comment with an URL to the corresponding pull-request or issue on the WPT github so it can be followed later easily in case of need.
> I will push the change upstream as soon as it has review here. (The wpt
> review policy just requires a review in some public place, to make this use
> case possible.)
You can use Tools/Scripts/export-w3c-tests for that purpose.
If this is your last commit locally, something like below should push the changes to your WPT clone:
Tools/Scripts/export-w3c-test-changes -b 182833 -g HEAD~1
Use -n to specific your GitHub username.
Use -t to specify the GitHub token that will allow the script to create the PR on WPT repo and -c to ask the script to do it.
Note that the guidelines are to first commit to WPT, then to WebKit.
At the moment, the WPT bot will probably ask for review for your PR.
ms2ger, let me know if you would like to be added to the list of authors for whose WebKit PR would be review skipped
(In reply to youenn fablet from comment #23) > At the moment, the WPT bot will probably ask for review for your PR. > ms2ger, let me know if you would like to be added to the list of authors for > whose WebKit PR would be review skipped That would be great! Submitted web-platform-tests pull request: https://github.com/w3c/web-platform-tests/pull/10630 Comment on attachment 338199 [details] Patch Landed in https://github.com/w3c/web-platform-tests/pull/10630 Comment on attachment 338199 [details] Patch Rejecting attachment 338199 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 338199, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ext/imagebitmap/createImageBitmap-origin.sub-expected.txt patching file LayoutTests/platform/ios/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt patching file LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7445329 Created attachment 338718 [details]
Patch
Comment on attachment 338718 [details] Patch Clearing flags on attachment: 338718 Committed r230990: <https://trac.webkit.org/changeset/230990> All reviewed patches have been landed. Closing bug. (In reply to Ms2ger from comment #24) > (In reply to youenn fablet from comment #23) > > At the moment, the WPT bot will probably ask for review for your PR. > > ms2ger, let me know if you would like to be added to the list of authors for > > whose WebKit PR would be review skipped > > That would be great! Submitted https://github.com/web-platform-tests/wpt-pr-bot/pull/18 |