RESOLVED FIXED 182833
imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-* LayoutTests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=182833
Summary imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-* Lay...
Ryan Haddad
Reported 2018-02-15 11:07:00 PST
The following LayoutTests are flaky failures on macOS and iOS after the tests were updated in https://trac.webkit.org/changeset/228003/webkit imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2F2dcontext%2Fimagebitmap%2FcreateImageBitmap The text diffs show a test harness timeout: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-actual.txt @@ -1,52 +1,53 @@ -CONSOLE MESSAGE: line 137: Canvas area exceeds the maximum limit (width * height > 268435456). + +Harness Error (TIMEOUT), message = null
Attachments
Patch (7.79 KB, patch)
2018-04-17 03:40 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Archive of layout-test-results from ews100 for mac-sierra (2.22 MB, application/zip)
2018-04-17 04:45 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.57 MB, application/zip)
2018-04-17 04:49 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.29 MB, application/zip)
2018-04-17 05:12 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews117 for mac-sierra (3.04 MB, application/zip)
2018-04-17 05:16 PDT, EWS Watchlist
no flags
Patch (9.59 KB, patch)
2018-04-17 06:27 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.33 MB, application/zip)
2018-04-17 07:59 PDT, EWS Watchlist
no flags
Patch (12.41 KB, patch)
2018-04-17 23:55 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Patch (12.59 KB, patch)
2018-04-25 04:24 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Ryan Haddad
Comment 1 2018-02-15 11:14:59 PST
Updated TestExpectations for macOS in https://trac.webkit.org/r228526
Alicia Boya García
Comment 2 2018-03-28 08:18:22 PDT
Same error on GTK, but more frequently.
Alicia Boya García
Comment 3 2018-03-28 13:05:05 PDT
Moved TestExpectations to base (multiplatform) file. https://trac.webkit.org/changeset/230034/webkit
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 4 2018-04-13 00:22:49 PDT
*** Bug 184562 has been marked as a duplicate of this bug. ***
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 5 2018-04-13 00:23:37 PDT
The problem here is that the video element sometimes doesn't load. I've been debugging, but haven't found the cause yet.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 6 2018-04-17 03:40:49 PDT
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 7 2018-04-17 03:42:13 PDT
The failure that happened at least one every hundred runs before this change, didn't occur in >1000 runs after the change.
EWS Watchlist
Comment 8 2018-04-17 04:45:03 PDT
Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7342418 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html
EWS Watchlist
Comment 9 2018-04-17 04:45:04 PDT
Created attachment 338099 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 10 2018-04-17 04:49:06 PDT
Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7342423 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html
EWS Watchlist
Comment 11 2018-04-17 04:49:07 PDT
Created attachment 338100 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 12 2018-04-17 05:12:35 PDT
Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7342444 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html
EWS Watchlist
Comment 13 2018-04-17 05:12:36 PDT
Created attachment 338101 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 14 2018-04-17 05:16:57 PDT
Comment on attachment 338096 [details] Patch Attachment 338096 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7342451 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html
EWS Watchlist
Comment 15 2018-04-17 05:16:58 PDT
Created attachment 338102 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 16 2018-04-17 06:27:19 PDT
EWS Watchlist
Comment 17 2018-04-17 07:59:07 PDT
Comment on attachment 338104 [details] Patch Attachment 338104 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7343576 New failing tests: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html
EWS Watchlist
Comment 18 2018-04-17 07:59:08 PDT
Created attachment 338111 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 19 2018-04-17 23:55:20 PDT
Carlos Alberto Lopez Perez
Comment 20 2018-04-18 09:53:18 PDT
Comment on attachment 338199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338199&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + * web-platform-tests/2dcontext/imagebitmap/common.sub.js: ensure event handlers aren't garbage collected > + * web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub-expected.txt: update expectations Which one is the policy for updating this tests (not the expectation, but the test itself) ?? Shouldn't we send a PR to https://github.com/w3c/web-platform-tests ?
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 21 2018-04-18 23:43:57 PDT
(In reply to Carlos Alberto Lopez Perez from comment #20) > Comment on attachment 338199 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338199&action=review > > > LayoutTests/imported/w3c/ChangeLog:9 > > + * web-platform-tests/2dcontext/imagebitmap/common.sub.js: ensure event handlers aren't garbage collected > > + * web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub-expected.txt: update expectations > > Which one is the policy for updating this tests (not the expectation, but > the test itself) ?? > Shouldn't we send a PR to https://github.com/w3c/web-platform-tests ? I will push the change upstream as soon as it has review here. (The wpt review policy just requires a review in some public place, to make this use case possible.)
Carlos Alberto Lopez Perez
Comment 22 2018-04-24 04:41:30 PDT
Comment on attachment 338199 [details] Patch r=me but please submit this changes on the tests to WPT and update this bug with a comment with an URL to the corresponding pull-request or issue on the WPT github so it can be followed later easily in case of need.
youenn fablet
Comment 23 2018-04-24 07:20:01 PDT
> I will push the change upstream as soon as it has review here. (The wpt > review policy just requires a review in some public place, to make this use > case possible.) You can use Tools/Scripts/export-w3c-tests for that purpose. If this is your last commit locally, something like below should push the changes to your WPT clone: Tools/Scripts/export-w3c-test-changes -b 182833 -g HEAD~1 Use -n to specific your GitHub username. Use -t to specify the GitHub token that will allow the script to create the PR on WPT repo and -c to ask the script to do it. Note that the guidelines are to first commit to WPT, then to WebKit. At the moment, the WPT bot will probably ask for review for your PR. ms2ger, let me know if you would like to be added to the list of authors for whose WebKit PR would be review skipped
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 24 2018-04-24 07:45:14 PDT
(In reply to youenn fablet from comment #23) > At the moment, the WPT bot will probably ask for review for your PR. > ms2ger, let me know if you would like to be added to the list of authors for > whose WebKit PR would be review skipped That would be great!
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 25 2018-04-25 02:12:48 PDT
Submitted web-platform-tests pull request: https://github.com/w3c/web-platform-tests/pull/10630
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 26 2018-04-25 04:08:54 PDT
WebKit Commit Bot
Comment 27 2018-04-25 04:09:56 PDT
Comment on attachment 338199 [details] Patch Rejecting attachment 338199 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 338199, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ext/imagebitmap/createImageBitmap-origin.sub-expected.txt patching file LayoutTests/platform/ios/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt patching file LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7445329
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 28 2018-04-25 04:24:21 PDT
WebKit Commit Bot
Comment 29 2018-04-25 05:10:48 PDT
Comment on attachment 338718 [details] Patch Clearing flags on attachment: 338718 Committed r230990: <https://trac.webkit.org/changeset/230990>
WebKit Commit Bot
Comment 30 2018-04-25 05:10:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 31 2018-04-25 05:11:38 PDT
youenn fablet
Comment 32 2018-05-11 05:36:30 PDT
(In reply to Ms2ger from comment #24) > (In reply to youenn fablet from comment #23) > > At the moment, the WPT bot will probably ask for review for your PR. > > ms2ger, let me know if you would like to be added to the list of authors for > > whose WebKit PR would be review skipped > > That would be great! Submitted https://github.com/web-platform-tests/wpt-pr-bot/pull/18
Note You need to log in before you can comment on or make changes to this bug.