Bug 182831

Summary: Finish unifying Apple Pay and Payment Request sources
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, beidson, commit-queue, dbates, keith_miller, sam, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2018-02-15 09:47:34 PST
Finish unifying Apple Pay and Payment Request sources
Attachments
Patch (11.03 KB, patch)
2018-02-15 09:49 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (12.25 KB, patch)
2018-02-15 10:07 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (17.02 KB, patch)
2018-02-15 10:47 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (17.33 KB, patch)
2018-02-15 11:12 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-02-15 09:49:29 PST
Created attachment 333907 [details] Patch
Andy Estes
Comment 2 2018-02-15 10:07:34 PST
Created attachment 333913 [details] Patch
Keith Miller
Comment 3 2018-02-15 10:34:58 PST
Comment on attachment 333913 [details] Patch r=me.
Keith Miller
Comment 4 2018-02-15 10:36:04 PST
Comment on attachment 333913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333913&action=review > Source/WebCore/SourcesCocoa.txt:-387 > - Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp Interesting that this was unsorted. Did you add this after my initial move to unified sources?
Andy Estes
Comment 5 2018-02-15 10:45:08 PST
(In reply to Keith Miller from comment #4) > Comment on attachment 333913 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=333913&action=review > > > Source/WebCore/SourcesCocoa.txt:-387 > > - Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp > > Interesting that this was unsorted. Did you add this after my initial move > to unified sources? Nope, looks like it was unsorted as of https://trac.webkit.org/r224027. Thanks for reviewing!
Andy Estes
Comment 6 2018-02-15 10:47:17 PST
Created attachment 333916 [details] Patch
Andy Estes
Comment 7 2018-02-15 11:12:04 PST
Created attachment 333918 [details] Patch
WebKit Commit Bot
Comment 8 2018-02-15 11:47:51 PST
Comment on attachment 333918 [details] Patch Clearing flags on attachment: 333918 Committed r228527: <https://trac.webkit.org/changeset/228527>
WebKit Commit Bot
Comment 9 2018-02-15 11:47:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-02-15 11:48:26 PST
<rdar://problem/37578376>
Note You need to log in before you can comment on or make changes to this bug.