Bug 182830

Summary:

[Modern Media Controls] REGRESSION: Inline media controls are not disabled while in fullscreen on iOS

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

iOS 11

See Also:

https://bugs.webkit.org/show_bug.cgi?id=182668
https://bugs.webkit.org/show_bug.cgi?id=180144

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Patch	none
Patch for landing	none

Antoine Quint

Reported 2018-02-15 05:56:07 PST

When fixing https://bugs.webkit.org/show_bug.cgi?id=182668, we regressed the behaviour introduced in https://bugs.webkit.org/show_bug.cgi?id=180144.

Attachments
Patch (2.99 KB, patch) 2018-02-15 06:00 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.21 MB, application/zip) 2018-02-15 07:00 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.16 MB, application/zip) 2018-02-15 07:05 PST, EWS Watchlist	no flags	Details
Patch (2.99 KB, patch) 2018-02-15 07:27 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (3.04 KB, patch) 2018-02-15 09:27 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2018-02-15 05:57:03 PST

<rdar://problem/37537909>

Antoine Quint

Comment 2 2018-02-15 06:00:33 PST

Created attachment 333895 [details] Patch

EWS Watchlist

Comment 3 2018-02-15 07:00:17 PST

Comment on attachment 333895 [details] Patch Attachment 333895 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6517149 New failing tests: media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html

EWS Watchlist

Comment 4 2018-02-15 07:00:18 PST

Created attachment 333897 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-02-15 07:05:12 PST

Comment on attachment 333895 [details] Patch Attachment 333895 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6517158 New failing tests: media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html

EWS Watchlist

Comment 6 2018-02-15 07:05:13 PST

Created attachment 333898 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Antoine Quint

Comment 7 2018-02-15 07:27:24 PST

Created attachment 333899 [details] Patch

Eric Carlson

Comment 8 2018-02-15 09:25:45 PST

Comment on attachment 333899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333899&action=review > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:310 > + // Controls are always available while in fullscreen on macOS. Nit: you might add something like this for clarity - ", and they are never available when in fullscreen on iOS".

Antoine Quint

Comment 9 2018-02-15 09:27:33 PST

Created attachment 333905 [details] Patch for landing

WebKit Commit Bot

Comment 10 2018-02-15 10:04:00 PST

Comment on attachment 333905 [details] Patch for landing Clearing flags on attachment: 333905 Committed r228519: <https://trac.webkit.org/changeset/228519>

WebKit Commit Bot

Comment 11 2018-02-15 10:04:02 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.