| Summary: | [Modern Media Controls] REGRESSION: Inline media controls are not disabled while in fullscreen on iOS | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, dino, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | iOS 11 | ||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=182668 https://bugs.webkit.org/show_bug.cgi?id=180144 |
||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Antoine Quint
2018-02-15 05:56:07 PST
Created attachment 333895 [details]
Patch
Comment on attachment 333895 [details] Patch Attachment 333895 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6517149 New failing tests: media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html Created attachment 333897 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333895 [details] Patch Attachment 333895 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6517158 New failing tests: media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html Created attachment 333898 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 333899 [details]
Patch
Comment on attachment 333899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333899&action=review > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:310 > + // Controls are always available while in fullscreen on macOS. Nit: you might add something like this for clarity - ", and they are never available when in fullscreen on iOS". Created attachment 333905 [details]
Patch for landing
Comment on attachment 333905 [details] Patch for landing Clearing flags on attachment: 333905 Committed r228519: <https://trac.webkit.org/changeset/228519> All reviewed patches have been landed. Closing bug. |