Bug 182801

Summary: Setting a VMTrap shouldn't look at topCallFrame since that may imply we're in C code and holding the malloc lock
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
keith_miller: review+
patch for landing none

Description Saam Barati 2018-02-14 11:32:44 PST 
...
Comment 1 Saam Barati 2018-02-14 12:23:22 PST 
Created attachment 333828 [details]
patch
Comment 2 Keith Miller 2018-02-14 12:26:10 PST 
Comment on attachment 333828 [details]
patch

r=me.
Comment 3 Saam Barati 2018-02-14 13:25:33 PST 
Comment on attachment 333828 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333828&action=review

> Tools/Scripts/run-jsc-stress-tests:725
> +            runFTLEagerWatchdog if rand(100) < 15

Gonna do this in a follow up patch. It requires some other changes.
Comment 4 Saam Barati 2018-02-14 13:31:10 PST 
Created attachment 333834 [details]
patch for landing
Comment 5 Saam Barati 2018-02-14 15:04:18 PST 
<rdar://problem/37550069>
Comment 6 WebKit Commit Bot 2018-02-14 15:25:58 PST 
Comment on attachment 333834 [details]
patch for landing

Clearing flags on attachment: 333834

Committed r228488: <https://trac.webkit.org/changeset/228488>
Comment 7 WebKit Commit Bot 2018-02-14 15:26:00 PST 
All reviewed patches have been landed.  Closing bug.