Bug 182787

Summary: Remove line without any effect.
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, dominik.infuehr, guijemont, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 mcatanzaro: review+, commit-queue: commit-queue-

Dominik Inführ
Reported 2018-02-14 03:54:07 PST
Created attachment 333784 [details] Patch The following line was supposed to skip the test on ARM-architectures. The condition never evaluates to true though, so the test isn't skipped. Remove the line since the test passes just fine on my Raspberry Pi 2.
Attachments
Patch (1.18 KB, patch)
2018-02-14 03:54 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.18 KB, patch)
2018-02-21 05:58 PST, Dominik Inführ 		mcatanzaro: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-02-21 05:58:15 PST
Created attachment 334368 [details] Patch v2
WebKit Commit Bot
Comment 2 2018-05-17 12:32:37 PDT
Comment on attachment 334368 [details] Patch v2 Rejecting attachment 334368 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 334368, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file JSTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JSTests/stress/new-largeish-contiguous-array-with-size.js Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file JSTests/stress/new-largeish-contiguous-array-with-size.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Catanzaro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7713406
Note You need to log in before you can comment on or make changes to this bug.