Bug 182783

Summary: [FTL] Support ArrayPop for ArrayStorage
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2018-02-14 03:02:39 PST
[FTL] Support ArrayPop for ArrayStorage
Attachments
Patch (7.37 KB, patch)
2018-02-14 03:03 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (7.90 KB, patch)
2018-02-14 03:08 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-02-14 03:03:42 PST
Created attachment 333778 [details] Patch
Yusuke Suzuki
Comment 2 2018-02-14 03:08:29 PST
Created attachment 333779 [details] Patch
Saam Barati
Comment 3 2018-02-19 18:55:53 PST
Comment on attachment 333779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333779&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4768 > + m_out.aboveOrEqual(newLength, m_out.load32(storage, m_heaps.Butterfly_vectorLength)), usually(slowCase), usually(popCheckCase)); You do 'usually' twice here. You probably want 'rarely(slowCase)'
Yusuke Suzuki
Comment 4 2018-02-19 20:02:14 PST
Comment on attachment 333779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333779&action=review Thanks! >> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4768 >> + m_out.aboveOrEqual(newLength, m_out.load32(storage, m_heaps.Butterfly_vectorLength)), usually(slowCase), usually(popCheckCase)); > > You do 'usually' twice here. You probably want 'rarely(slowCase)' Right, I'll change this to `rarely(slowCase)`.
Yusuke Suzuki
Comment 5 2018-02-19 20:33:39 PST
Committed r228727: <https://trac.webkit.org/changeset/228727>
Radar WebKit Bug Importer
Comment 6 2018-02-19 20:34:25 PST
<rdar://problem/37696362>
Note You need to log in before you can comment on or make changes to this bug.