Bug 182755

Summary: putDirectIndexSlowOrBeyondVectorLength needs to convert to dictionary indexing mode always if attributes are present
Product: WebKit Reporter: Saam Barati <sbarati>
Component: JavaScriptCoreAssignee: Saam Barati <sbarati>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2018-02-13 17:02:24 PST
Right now, it just checks if the index being stored to is less than vector length. That makes no sense. We always need to convert to dictionary indexing mode if we're dealing w/ setters/getters/readonly props.
Comment 1 Saam Barati 2018-02-13 17:03:10 PST
<rdar://problem/37080864>
Comment 2 Saam Barati 2018-02-13 17:09:34 PST
Created attachment 333751 [details]
patch
Comment 3 Keith Miller 2018-02-13 17:41:56 PST
Comment on attachment 333751 [details]
patch

r=me.
Comment 4 WebKit Commit Bot 2018-02-13 21:07:12 PST
Comment on attachment 333751 [details]
patch

Clearing flags on attachment: 333751

Committed r228454: <https://trac.webkit.org/changeset/228454>
Comment 5 WebKit Commit Bot 2018-02-13 21:07:13 PST
All reviewed patches have been landed.  Closing bug.