Bug 182755 - putDirectIndexSlowOrBeyondVectorLength needs to convert to dictionary indexing mode always if attributes are present
Summary: putDirectIndexSlowOrBeyondVectorLength needs to convert to dictionary indexin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-13 17:02 PST by Saam Barati
Modified: 2018-02-13 21:07 PST (History)
13 users (show)

See Also:

Attachments
patch (6.28 KB, patch)
2018-02-13 17:09 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-02-13 17:02:24 PST 
Right now, it just checks if the index being stored to is less than vector length. That makes no sense. We always need to convert to dictionary indexing mode if we're dealing w/ setters/getters/readonly props.
Comment 1 Saam Barati 2018-02-13 17:03:10 PST 
<rdar://problem/37080864>
Comment 2 Saam Barati 2018-02-13 17:09:34 PST 
Created attachment 333751 [details]
patch
Comment 3 Keith Miller 2018-02-13 17:41:56 PST 
Comment on attachment 333751 [details]
patch

r=me.
Comment 4 WebKit Commit Bot 2018-02-13 21:07:12 PST 
Comment on attachment 333751 [details]
patch

Clearing flags on attachment: 333751

Committed r228454: <https://trac.webkit.org/changeset/228454>
Comment 5 WebKit Commit Bot 2018-02-13 21:07:13 PST 
All reviewed patches have been landed.  Closing bug.