RESOLVED FIXED182755
putDirectIndexSlowOrBeyondVectorLength needs to convert to dictionary indexing mode always if attributes are present 
https://bugs.webkit.org/show_bug.cgi?id=182755
Summary putDirectIndexSlowOrBeyondVectorLength needs to convert to dictionary indexin...
Saam Barati
Reported 2018-02-13 17:02:24 PST
Right now, it just checks if the index being stored to is less than vector length. That makes no sense. We always need to convert to dictionary indexing mode if we're dealing w/ setters/getters/readonly props.
Attachments
patch (6.28 KB, patch)
2018-02-13 17:09 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-02-13 17:03:10 PST
<rdar://problem/37080864>
Saam Barati
Comment 2 2018-02-13 17:09:34 PST
Created attachment 333751 [details] patch
Keith Miller
Comment 3 2018-02-13 17:41:56 PST
Comment on attachment 333751 [details] patch r=me.
WebKit Commit Bot
Comment 4 2018-02-13 21:07:12 PST
Comment on attachment 333751 [details] patch Clearing flags on attachment: 333751 Committed r228454: <https://trac.webkit.org/changeset/228454>
WebKit Commit Bot
Comment 5 2018-02-13 21:07:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.