| Summary: | [Curl] Curl Cookie Database File should be configurable using NetworkProcessCreationParameters | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Christopher Reid <chris.reid> | ||||||||
| Component: | Platform | Assignee: | Christopher Reid <chris.reid> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, annulen, beidson, bfulgham, cdumez, chris.reid, commit-queue, darin, don.olmstead, ews-watchlist, galpeter, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Christopher Reid
2018-02-13 16:22:00 PST
Created attachment 333746 [details]
patch
Attachment 333746 [details] did not pass style-queue:
ERROR: Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:50: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 333748 [details]
patch
Fixing style issues
Comment on attachment 333748 [details] patch I do not see anything wrong there related to the 'OWNER' side. I am not very familiar with CURL, it would be good if somebody more familiar could take an additional look. View in context: https://bugs.webkit.org/attachment.cgi?id=333748&action=review > Source/WebKit/ChangeLog:10 > + This is parameter is not used yet, it is added to prepare for WinCairo WebKit support. s/This is/This/ Was there discussion on the mailing list about adding support for Windows to WebKit2? Created attachment 334413 [details]
Patch for landing
(In reply to Chris Dumez from comment #5) > Was there discussion on the mailing list about adding support for Windows to > WebKit2? I don't think there was too much discussion about adding WebKit 2 support for WinCairo on the mailing list yet. Don has mentioned that was something we were working in one of our updates here: https://lists.webkit.org/pipermail/webkit-dev/2017-November/029783.html. We are very much interested in working towards WebKit2 support including getting WebKit2 WinCairo buildbots going. Let us know if you would like to see the discussion opened up on the mailing list some more. Its actually been longer than that https://lists.webkit.org/pipermail/webkit-dev/2017-August/029329.html Comment on attachment 334413 [details] Patch for landing Clearing flags on attachment: 334413 Committed r228905: <https://trac.webkit.org/changeset/228905> All reviewed patches have been landed. Closing bug. |