Bug 182740

Summary: [GTK][WPE] Fullscreen video is broken
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: MediaAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: magomez, mcatanzaro, Ms2ger, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mcatanzaro: review+

Michael Catanzaro
Reported 2018-02-13 12:26:58 PST
Load https://bug791090.bugzilla-attachments.gnome.org/attachment.cgi?id=368326 Try to click the fullscreen icon, or right click and "switch video to fullscreen". Nothing happens. This is using 2.19.90.
Attachments
Patch (2.03 KB, patch)
2018-02-16 01:18 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (2.04 KB, patch)
2018-02-16 01:19 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (2.03 KB, patch)
2018-02-16 02:42 PST, Philippe Normand 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-02-15 07:39:04 PST
ENABLE(VIDEO_USES_ELEMENT_FULLSCREEN) is not enabled and should be enabled for the GTK and WPE ports. What's the best way to enable it?
Michael Catanzaro
Comment 2 2018-02-15 10:40:31 PST
Add it to WebKitFeatures.cmake, default to ON, and add a WEBKIT_OPTION_DEPEND to make it depend on ENABLE_VIDEO.
Philippe Normand
Comment 3 2018-02-16 01:18:46 PST
Created attachment 334022 [details] Patch
Philippe Normand
Comment 4 2018-02-16 01:19:30 PST
Created attachment 334023 [details] Patch
Philippe Normand
Comment 5 2018-02-16 02:42:05 PST
Created attachment 334029 [details] Patch
Michael Catanzaro
Comment 6 2018-02-16 09:25:37 PST
Comment on attachment 334029 [details] Patch My question is: for how long has this been broken? Surely it used to work...?
Philippe Normand
Comment 7 2018-02-16 14:45:33 PST
It's been broken for 3 months. See also https://bugs.webkit.org/show_bug.cgi?id=179721
Philippe Normand
Comment 8 2018-02-18 23:44:01 PST
*** Bug 182109 has been marked as a duplicate of this bug. ***
Philippe Normand
Comment 9 2018-02-18 23:44:12 PST
*** Bug 179721 has been marked as a duplicate of this bug. ***
Philippe Normand
Comment 10 2018-02-18 23:48:04 PST
https://trac.webkit.org/changeset/228608/webkit
Radar WebKit Bug Importer
Comment 11 2018-02-18 23:49:22 PST
<rdar://problem/37662566>
Note You need to log in before you can comment on or make changes to this bug.