Bug 182734

Summary:

[RenderTreeBuilder] Move RenderGrid::takeChild() to RenderTreeBuilder

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra	none
Patch	none

Description zalan 2018-02-13 09:42:56 PST

ssia

Comment 1 Radar WebKit Bug Importer 2018-02-13 09:43:22 PST

<rdar://problem/37500876>

Comment 2 zalan 2018-02-13 09:53:20 PST

Created attachment 333696 [details]
Patch

Comment 3 EWS Watchlist 2018-02-13 10:54:40 PST

Comment on attachment 333696 [details]
Patch

Attachment 333696 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6484826

New failing tests:
fast/css-grid-layout/grid-item-removal-track-breadth-update.html
fast/css-grid-layout/grid-item-removal-auto-placement-update.html

Comment 4 EWS Watchlist 2018-02-13 10:54:41 PST

Created attachment 333706 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 5 zalan 2018-02-13 11:10:02 PST

Created attachment 333707 [details]
Patch

Comment 6 WebKit Commit Bot 2018-02-13 11:52:51 PST

Comment on attachment 333707 [details]
Patch

Clearing flags on attachment: 333707

Committed r228428: <https://trac.webkit.org/changeset/228428>

Comment 7 WebKit Commit Bot 2018-02-13 11:52:52 PST

All reviewed patches have been landed.  Closing bug.