Bug 182734 - [RenderTreeBuilder] Move RenderGrid::takeChild() to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderGrid::takeChild() to RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-13 09:42 PST by zalan
Modified: 2018-02-13 11:52 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.17 KB, patch)
2018-02-13 09:53 PST, zalan 		koivisto: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.20 MB, application/zip)
2018-02-13 10:54 PST, EWS Watchlist 		no flags Details
Patch (5.78 KB, patch)
2018-02-13 11:10 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-13 09:42:56 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-13 09:43:22 PST 
<rdar://problem/37500876>
Comment 2 zalan 2018-02-13 09:53:20 PST 
Created attachment 333696 [details]
Patch
Comment 3 EWS Watchlist 2018-02-13 10:54:40 PST 
Comment on attachment 333696 [details]
Patch

Attachment 333696 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6484826

New failing tests:
fast/css-grid-layout/grid-item-removal-track-breadth-update.html
fast/css-grid-layout/grid-item-removal-auto-placement-update.html
Comment 4 EWS Watchlist 2018-02-13 10:54:41 PST 
Created attachment 333706 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 zalan 2018-02-13 11:10:02 PST 
Created attachment 333707 [details]
Patch
Comment 6 WebKit Commit Bot 2018-02-13 11:52:51 PST 
Comment on attachment 333707 [details]
Patch

Clearing flags on attachment: 333707

Committed r228428: <https://trac.webkit.org/changeset/228428>
Comment 7 WebKit Commit Bot 2018-02-13 11:52:52 PST 
All reviewed patches have been landed.  Closing bug.