Bug 182716

Summary: Unify UserAgent into WebCore/platform.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: PlatformAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, don.olmstead, mcatanzaro, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2018-02-12 16:03:23 PST
Unify UserAgent into WebCore/platform (thereby addressing the FIXME leftover by https://bugs.webkit.org/show_bug.cgi?id=163508#c5).
Attachments
Patch (35.51 KB, patch)
2018-02-12 16:44 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-02-12 16:44:12 PST
Created attachment 333644 [details] Patch
Michael Catanzaro
Comment 2 2018-02-12 17:20:55 PST
Comment on attachment 333644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333644&action=review Nice, thanks. > Source/WebCore/platform/UserAgent.h:-32 > -#if PLATFORM(COCOA) > -// FIXME: Remove Source/WebCore/page/cocoa/UserAgent.h > -#include_next "UserAgent.h" > -#else Wow, I forgot that #include_next existed. That was awful.
WebKit Commit Bot
Comment 3 2018-02-12 18:26:22 PST
Comment on attachment 333644 [details] Patch Clearing flags on attachment: 333644 Committed r228413: <https://trac.webkit.org/changeset/228413>
WebKit Commit Bot
Comment 4 2018-02-12 18:26:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-02-12 18:27:36 PST
<rdar://problem/37482805>
Note You need to log in before you can comment on or make changes to this bug.